Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now we can build with multiple tags in "buildtest build --tags" #462

Merged

Conversation

shahzebsiddiqui
Copy link
Member

Fix bug where we didn't raise error when we had no buildspec to process
after parse stage. This was reproduced when building the invalid buildspec and
executor example in tutorials.
Add tags 'compiler', 'python' in tutorials test to demonstrate tests with multi-tag example
rebuild documentation examples and add example using multi tags and combining tags
with buildspecs

Fix bug where we didn't raise error when we had no buildspec to process
after parse stage. This was reproduced when building the invalid buildspec and
executor example in tutorials.
Add tags 'compiler', 'python' in tutorials test to demonstrate tests with multi-tag example
rebuild documentation examples and add example using multi tags and combining tags
with buildspecs
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 10, 2020
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #462 into devel will decrease coverage by 0.08%.
The diff coverage is 26.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel     #462      +/-   ##
==========================================
- Coverage   72.80%   72.72%   -0.08%     
==========================================
  Files          26       26              
  Lines        1761     1767       +6     
  Branches      287      290       +3     
==========================================
+ Hits         1282     1285       +3     
- Misses        401      404       +3     
  Partials       78       78              
Impacted Files Coverage Δ
buildtest/menu/__init__.py 40.00% <ø> (ø)
buildtest/menu/buildspec.py 77.66% <10.00%> (-1.14%) ⬇️
buildtest/menu/build.py 69.12% <60.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab032d6...6be61bc. Read the comment docs.

@shahzebsiddiqui shahzebsiddiqui merged commit acb0f97 into buildtesters:devel Sep 10, 2020
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 10, 2020
shahzebsiddiqui added a commit that referenced this pull request Sep 14, 2020
Fix bug where we didn't raise error when we had no buildspec to process
after parse stage. This was reproduced when building the invalid buildspec and
executor example in tutorials.
Add tags 'compiler', 'python' in tutorials test to demonstrate tests with multi-tag example
rebuild documentation examples and add example using multi tags and combining tags
with buildspecs
@shahzebsiddiqui shahzebsiddiqui deleted the build_by_multitags branch September 21, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant