Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for profiles #1489

Merged
merged 22 commits into from
Jun 12, 2023
Merged

Add support for profiles #1489

merged 22 commits into from
Jun 12, 2023

Conversation

shahzebsiddiqui
Copy link
Member

No description provided.

…onschema to ensure each property type matches the input type

used in BuildTest class.

For 'buildspecs' property we resolve the full path before adding to configuration file since we will need this inorder to know where buildspec is.
… and override the class variables.

Add method in SiteConfiguration class called 'get_profile' which will retrieve the profile given the name of profile specified
by --profile. If profile doesn't exist or no profiles are created we raise and exception.
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.70 🎉

Comparison is base (d36e315) 75.50% compared to head (33d9f7b) 76.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1489      +/-   ##
==========================================
+ Coverage   75.50%   76.20%   +0.70%     
==========================================
  Files          57       57              
  Lines        6568     6619      +51     
==========================================
+ Hits         4959     5044      +85     
+ Misses       1609     1575      -34     
Impacted Files Coverage Δ
buildtest/buildsystem/builders.py 82.16% <ø> (+3.24%) ⬆️
buildtest/cli/__init__.py 100.00% <100.00%> (ø)
buildtest/cli/build.py 95.95% <100.00%> (+3.07%) ⬆️
buildtest/cli/buildspec.py 93.87% <100.00%> (+0.16%) ⬆️
buildtest/cli/help.py 100.00% <100.00%> (ø)
buildtest/config.py 51.22% <100.00%> (+1.47%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

…rofile since this

is handled earlier in codebase when invoking SiteConfiguration class.
copy the config.yml from devel branch since we accidently updated the content of default configuration file which removed the comments
make minor changes to documentation
…o allow filter

by tags, maintainers and type.
…e for '--executor-type'.

Also check if --module-purge is passed then check if key is False if so we set to None so its not written in configuration file
update regression test to test for 'executor-type'.
Also check when 'module-purge' is not passed as an option when saving profile configuration
@shahzebsiddiqui shahzebsiddiqui merged commit 6b6277c into devel Jun 12, 2023
@shahzebsiddiqui shahzebsiddiqui deleted the buildtest_profiles branch June 12, 2023 22:57
@shahzebsiddiqui shahzebsiddiqui linked an issue Jul 5, 2023 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: add support for multiple profiles during buildtest build
1 participant