New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add status check for Symlink check #1394

Merged

shahzebsiddiqui merged 17 commits into devel from symlink_check

Feb 21, 2023

Collaborator

prathmesh4321 commented Feb 16, 2023

No description provided.

prathmesh4321 added 4 commits

February 15, 2023 16:19


          Added json schema for symlink check

84a0848


          Added buildspec for symlink status check

cb16a65


          Added function for symlink check

afb6c77


          Added test in test_builders.py

672ec12

pull-request-size bot added the size/M label

prathmesh4321 linked an issue

that may be closed by this pull request

symlink check for status #1330

Closed

shahzebsiddiqui reviewed

View reviewed changes

buildtest/buildsystem/checks.py Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

tutorials/test_status/is_symlink.yml Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

tutorials/test_status/is_symlink.yml Outdated Show resolved Hide resolved


          Updated function to handle broken symlinks and shell expansions

shahzebsiddiqui reviewed

View reviewed changes

buildtest/buildsystem/checks.py Outdated Show resolved Hide resolved


          Added portable method is_symlink

f286c96

shahzebsiddiqui reviewed

View reviewed changes

buildtest/buildsystem/checks.py Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

buildtest/utils/file.py Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

buildtest/utils/file.py Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

buildtest/utils/file.py Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

buildtest/utils/file.py Outdated Show resolved Hide resolved


          Renamed variables and fixed docstrings

36f0a46

shahzebsiddiqui reviewed

View reviewed changes

buildtest/buildsystem/checks.py Outdated Show resolved Hide resolved

Member

shahzebsiddiqui commented Feb 17, 2023

@prathmesh4321 apart from this please try to add the following:

Documentation
Test Coverage
Add valid example on is_symlink in https://github.com/buildtesters/buildtest/blob/devel/buildtest/schemas/examples/script.schema.json/valid/examples.yml

So far looking pretty good


          Added test coverage for is_symlink method

3dd74a2

pull-request-size bot added size/L and removed size/M labels

Collaborator Author

prathmesh4321 commented Feb 18, 2023

@prathmesh4321 apart from this please try to add the following:

Documentation

Test Coverage

Add valid example on is_symlink in https://github.com/buildtesters/buildtest/blob/devel/buildtest/schemas/examples/script.schema.json/valid/examples.yml

So far looking pretty good

Okay, I have added the test coverage. Yet to add the documentation and example.

prathmesh4321 added 2 commits

February 17, 2023 18:33


          Removed unused os.path

3c92fab


          Added valid example in examples.yml

b5c81fb

shahzebsiddiqui reviewed

View reviewed changes

tests/utils/test_file.py Outdated Show resolved Hide resolved


          Added documentation and updated test_file.py

0ab0b0b

prathmesh4321 requested a review from shahzebsiddiqui

February 21, 2023 19:01

shahzebsiddiqui reviewed

View reviewed changes

docs/buildspecs/buildspec_overview.rst Outdated Show resolved Hide resolved

shahzebsiddiqui reviewed

View reviewed changes

docs/buildspecs/buildspec_overview.rst Outdated Show resolved Hide resolved

prathmesh4321 added 2 commits

February 21, 2023 12:09


          Rephrased sentences in the documentation

418a46a


          Fixed yamllint

532f8d1

shahzebsiddiqui reviewed

View reviewed changes

tests/utils/test_file.py Outdated Show resolved Hide resolved

prathmesh4321 added 2 commits

February 21, 2023 12:34


          Fixed yamllint check errors

01d6310


          Updated symlink test in test_file.py

1e40638

shahzebsiddiqui reviewed

View reviewed changes

tests/utils/test_file.py Outdated Show resolved Hide resolved


          Added os.path.basename instead of using arrays for getting filename

d23220b

shahzebsiddiqui assigned prathmesh4321


          Removed hardcoded path for is_symlink.yml

c8c8c84

Member

shahzebsiddiqui commented Feb 21, 2023

thanks @prathmesh4321 the CI checks are passing now that symlink is removed. Great job!

shahzebsiddiqui merged commit 1705f43 into devel

shahzebsiddiqui deleted the symlink_check branch

February 21, 2023 23:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels