limit output of buildtest report #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@Xiangs18 this looks good. Can you share the output i think this looks perfect. I presume this won't work with terse mode |
|
Hi @shahzebsiddiqui, this won't work with terse mode buildtest rt --terse --count=1 |
|
Hi @shahzebsiddiqui, now it works with terse mode as well. Thank you! |
shahzebsiddiqui
requested changes
Jun 30, 2022
tests/cli/test_report.py
Outdated
Comment on lines
238
to
256
| def test_report_limited_rows(): | ||
| class args: | ||
| filter = None | ||
| format = None | ||
| start = None | ||
| end = None | ||
| failure = None | ||
| latest = False | ||
| oldest = False | ||
| report_file = None | ||
| pager = None | ||
| terse = None | ||
| no_header = None | ||
| report_subcommand = None | ||
| helpfilter = False | ||
| helpformat = False | ||
| count = 5 | ||
|
|
||
| report_cmd(args) |
There was a problem hiding this comment.
Can you add another test with terse mode so just create another invocation to args . Alternately we may want to rewrite this test to directly call Report class directly. Either way works
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @shahzebsiddiqui, please see if further changes are required. Thank you!