Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify launcher env #207

Merged

Conversation

natalieparellano
Copy link
Member

Fixes (maybe) #162

@natalieparellano natalieparellano requested a review from a team as a code owner March 12, 2021 21:27
@nebhale nebhale requested a review from a team March 17, 2021 18:06
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@ekcasey
Copy link
Member

ekcasey commented Mar 18, 2021

@natalieparellano I think to fully resolve the issue brought up in #162 we should open a separate PR to the platform spec that reorganized the Environment section.

The Current Organitzation is

  • Environment
    • Buildpack Environment
      • Stack-Provided Variables
      • User-Provided Variables
    • Launch Environment

But I think, to cover all of the cases clearly we want something more like:

  • Environment
    • Buildpack Environment
      • Stack-Provided Variables
      • User-Provided Variables
      • Buildpack-Provided Variables
    • Launch Environment
      • Stack-Provided Variables
      • User-Provided Variables
      • Buildpack-Provided Variables

Signed-off-by: Natalie Arellano <narellano@vmware.com>

Co-authored-by: Emily Casey <emilykimballcasey@gmail.com>
@natalieparellano
Copy link
Member Author

@ekcasey I agree with your suggestion. Should we re-point #162 at Buildpack 0.7? We could keep this PR as a small incremental improvement, or just save everything for later. But I fear that keeping #162 in Buildpack 0.6 will delay the 0.6 release longer than we might like.

@nebhale nebhale self-requested a review March 24, 2021 16:33
@nebhale nebhale requested a review from a team March 24, 2021 16:33
@nebhale nebhale added this to the Buildpack 0.6 milestone Mar 24, 2021
@nebhale nebhale requested review from a team and ekcasey March 24, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe the Role of the Launcher in Setting Buildpack-Provided Environment Variables
5 participants