-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify launcher env #207
Merged
nebhale
merged 3 commits into
buildpacks:buildpack/0.6
from
natalieparellano:clarify-launcher-env
Mar 24, 2021
Merged
Clarify launcher env #207
nebhale
merged 3 commits into
buildpacks:buildpack/0.6
from
natalieparellano:clarify-launcher-env
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
approved these changes
Mar 17, 2021
nebhale
suggested changes
Mar 17, 2021
Signed-off-by: Natalie Arellano <narellano@vmware.com>
b67d822
to
82a5b9f
Compare
ekcasey
requested changes
Mar 18, 2021
@natalieparellano I think to fully resolve the issue brought up in #162 we should open a separate PR to the platform spec that reorganized the Environment section. The Current Organitzation is
But I think, to cover all of the cases clearly we want something more like:
|
Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Emily Casey <emilykimballcasey@gmail.com>
nebhale
approved these changes
Mar 24, 2021
hone
approved these changes
Mar 24, 2021
ekcasey
approved these changes
Mar 24, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes (maybe) #162