Updates exec.d on Windows #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jkutner
approved these changes
Mar 10, 2021
ekcasey
requested changes
Mar 11, 2021
There was a problem hiding this comment.
I am suggesting that we list the handle itself and the environment variable containing the handle number as two separate inputs. Then we can make it clear that users should write output to the handle instead of setting the environment variable.
Probably nobody would be confused by the previous usage, but I think this is more accurate (?).
Signed-off-by: Natalie Arellano <narellano@vmware.com> Co-authored-by: Emily Casey <emilykimballcasey@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
nebhale
approved these changes
Mar 17, 2021
ekcasey
approved these changes
Mar 18, 2021
jkutner
approved these changes
Mar 23, 2021
hone
approved these changes
Mar 24, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Natalie Arellano narellano@vmware.com