Support yj's updated download filename #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of `yj` 5.1.0+ the filename of the asset attached to the GitHub release is now `yj-linux-arm64` instead of `yj-linux`. This change ensures that the new yj default (as of buildpacks#164) is able to be downloaded, since currently the action fails with: ``` Installing yj 5.1.0 curl: (22) The requested URL returned error: 404 Error: Process completed with exit code 22. ``` The bash string comparison of the semver version isn't ideal, but it doesn't feel worth adding further complexity given that: - all `yj` releases so far use a full semver version (and not say an `X.Y` version) - `yj` major releases are infrequent, so it's going to be a while before v10 is out (which would break the comparison) - by which point this backwards compatibiluty comparison can just be removed (and support for pre 5.1.0 removed). Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
edmorley
force-pushed
the
support-new-yj-filename
branch
from
66a27c6 to
48a6c34
Compare
jkutner
approved these changes
Jan 4, 2023
jkutner
added
type:enhancement
|
@jkutner Thank you for the review/merge. I don't suppose you could release v5.0.1 of the action, so as to fix the stable latest |
|
done. thanks for the nudge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of
yj5.1.0+ the filename of the asset attached to the GitHub release is nowyj-linux-arm64instead ofyj-linux.For example:
https://github.com/sclevine/yj/releases/tag/v5.1.0
vs
https://github.com/sclevine/yj/releases/tag/v5.0.0
This change ensures that the new yj default (as of #164; which updated the default yj from
5.0.0to5.1.0) is able to be downloaded, since currently thesetup-toolsaction fails with:The bash string comparison of the semver version isn't ideal, but it doesn't feel worth adding further complexity given that:
yjreleases so far use a full semver version (and not say anX.Yversion)yjmajor releases are infrequent, so it's going to be a while before v10 is out (which would break the comparison) - by which point this backwards compatibility comparison can just be removed (and support for pre v5.1.0 removed).