Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more accurate using of instance/class/entity #230

Merged
merged 1 commit into from
Mar 6, 2024
Merged

more accurate using of instance/class/entity #230

merged 1 commit into from
Mar 6, 2024

Conversation

I-Sokolov
Copy link
Contributor

@I-Sokolov I-Sokolov commented Dec 21, 2023 •
edited
Loading

@I-Sokolov I-Sokolov mentioned this pull request Dec 21, 2023
Closed
@aothms
Copy link

aothms commented Dec 22, 2023

Looks great to me. Going over this I noticed:

the Predefined Type may also contain custom values by the user.

Maybe this needs a slight rewrite? Thoughts?

the Predefined Type in IFC can also be set to NOTDEFINED or USERDEFINED. In the latter case, in IFC, the user-defined value is then provided by another attribute on that type as a freeform text field. In IDS this is handled transparently as if the user provided value were assigned to the PredefinedType field directly.

@CBenghi CBenghi self-assigned this Feb 27, 2024
@CBenghi CBenghi added the documentation Improvements or additions to documentation label Feb 27, 2024
@CBenghi CBenghi added this to the 1.0 milestone Feb 27, 2024
@CBenghi CBenghi changed the base branch from master to development March 6, 2024 17:46
@CBenghi CBenghi merged commit 4b1db14 into buildingSMART:development Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aothms aothms aothms approved these changes

Assignees

@CBenghi CBenghi

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@I-Sokolov @aothms @CBenghi