Fix dev examples #148
Merged
Fix dev examples #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might change in the future, depending on buildingSMART#132, but for the time being `IfcBuildingStorey` is invalid.
This might change in the future, also depending from a parallel conversation happening on buildingSMART#132, but for the time being 'name' is not a valid attribute name; it should be capitalized ('Name').
- Uppercase for types in enumeration - Mismatch of case for 'Name' (was 'name') - totalDigits is not valid for xs:string (use length instead) - formatting of xs:annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed development IDS examples to comply with #137 and #147.
This also includes minor changes previously suggested in #142 and #139, which I'll close soon.
Because in my branch I hade quite a few commits feel free to squash.