-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to deal with xs:restriction base attribute in relation with IfcMeasure value #36
Comments
- added ifcMeasure element to properties; guided by https://github.com/buildingSMART/IDS/wiki/Physical-Quantities-and-Units Please review before further extending the enumeration list in teh XSD. - updated random example to remove inconsistency #20 - updated prefab pipes example to reflect ifcMeasure update; please review #36 on this
This is an important topic. Equality of floating point numbers should generally always be considering a tolerance value, due to rounding errors and all. For that same reason inclusive and exclusive generally don't make a big difference when comparing floating point numbers.
I don't expect huge demand for constrained floats, so I think we should be pragmatic about it, but also explicit. |
I think the restriction base shouldn't be integer, since the properties are almost always floating point numbers. The values in the restriction should always be given in the same based unit that is given for the measure. So if there's a requirement, that a temperature should be between 20 to 25 degrees Celsius. The limits in IDS should be 293.15 and 298.15, since temperature is given in Kelvin. |
This is now solved with the settlement of the measures |
The commit adds a new file "tolerance.md" to the Documentation directory. This file summarizes the discussions and comments made in issues buildingSMART#78 and buildingSMART#36 regarding tolerance in IDS
IfcMeasure element is now added to properties (please review).
There are a couple of comments and open questions:
For example IfcAreaMeasure is defined as being given in square meters (m2) in the IDS (defined on https://github.com/buildingSMART/IDS/wiki/Physical-Quantities-and-Units).
For the value in the property value element it means restrictions need to be in m2. For example a pipe needs to have a value between 2 and 6 square meters.
This means the restrictions need to be addressed as:
<xs:restriction base="xs:integer">
<xs:minInclusive value="2"/>
<xs:maxInclusive value="6"/>
</xs:restriction>
The minInclusive and MaxInclusive are defined by the 'base' attribute in the xs:restriction element. In this example set as 'integer'.
What is the implication of the value of this 'base' element for using fixed physical quantities and units?
The text was updated successfully, but these errors were encountered: