Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] React Adapter #1

Merged
merged 3 commits into from
Dec 17, 2023
Merged

[Draft] React Adapter #1

merged 3 commits into from
Dec 17, 2023

Conversation

PedroAugustoRamalhoDuarte

Hello, i would like the frame feature in React. So i want to make a POC with React, and its works well.

Todos

  • This line in the router is bugging for me visitId === this.visitId is never true
  • Render componente in frame with layout
  • Improve FrameContext
  • Make other code know the frame like: useForm
  • Refactor

@buhrmi
Copy link
Owner

buhrmi commented Dec 17, 2023

hey there, of course I'm merging this PR. But please note that this will never make it into any official inertia release. Even if @reinink considered it, I'd advise against it, because even though this feature is supercool, it needs a total rewrite.

@buhrmi buhrmi merged commit ed74ff7 into buhrmi:frames Dec 17, 2023
@PedroAugustoRamalhoDuarte
Copy link
Author

Thanks man, I know is very hard to merge this PR, but if you need any help i am here to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants