Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate builtin #5

Closed
wants to merge 73 commits into from
Closed

Migrate builtin #5

wants to merge 73 commits into from

Conversation

buffalojoec
Copy link
Owner

[DRAFT]

pgarg66 and others added 30 commits January 11, 2024 16:54
@pgarg66
Move EMA and stream throttling code to a new file (solana-labs#34759)
22fcffe
Populate partitioned-rewards PDA during calculation (solana-labs#34624)
4385ed1 
* Add epoch_rewards_partition_data module

* Rename variable

* Pass hasher's parent_blockhash up to begin_partitioned_rewards

* Populate epoch rewards partition data account in begin_partitioned_rewards

* Fix method name
@samkim-crypto
[zk-token-proof] include VerifyBatchRangeProofU256 in the `enable_z…
bc13642 
…k_transfer_with_fee` feature gate (solana-labs#34747)

include `VerifyBatchRangeProofU256` in the `enable_zk_transfer_with_fee` feature
@apfitzge
earlier fee payer validation (solana-labs#34666)
be5337a
@apfitzge
consumer bench same number of txs per iteration (solana-labs#34752)
98a2873
@apfitzge
TransactionScheduler: Add funded check before graph insertion (solana…
beef847 
…-labs#34699)
@tao-stones
cleanup feature code after activation (solana-labs#34695)
51eaa2b 
cleanup feature checking code
@samkim-crypto @joncinque
[zk-token-proof] Add functionality to read proof from accounts instea…
b222fdf 
…d of instruction data (solana-labs#34750)

* add functionality to read proof from accounts instead of instruction data

* update add tests

* clippy

* clarify instruction data discriminator

* avoid cloning entire proof data

* Update programs/zk-token-proof/src/lib.rs

Co-authored-by: Jon C <me@jonc.dev>

* update `PROOF_OFFSET_LENGTH` to `INSTRUCTION_DATA_LENGTH_WITH_PROOF_ACCOUNT`

* update instruction docs

* add feature gate

* Update sdk/src/feature_set.rs

Co-authored-by: Jon C <me@jonc.dev>

* update feature name `enable_zk_from_account` to `enable_zk_proof_from_account`

* Apply suggestions from code review

Co-authored-by: Jon C <me@jonc.dev>

* clarify the instruction data length more precisely

---------

Co-authored-by: Jon C <me@jonc.dev>
@tao-stones
removed obsolete field from cost_tracker (solana-labs#34762)
613f0ff
@apfitzge
Add benchmark for execute_batch (solana-labs#34717)
257ba2f
use staked connection for bench-tps in net scripts (solana-labs#34767)
5a1a697 
* add client-node-id to use staked connection

* Add flag to use unstaked connection for bench-tps

* Add bind-address for multinode

* always specify url for bench-tps
@samkim-crypto
[zk-token-proof] Increase compute budget for zk-token-proof tests (so…
9468996 
…lana-labs#34777)

increase compute budget for zk-token-proof tests
@pgarg66
Fix determination of staked QUIC connections (solana-labs#34760)
f92275b 
* Fix determination of staked QUIC connections

* address review comments

* review comments

* treat connections with zero stake as unstaked
@HaoranYi
Upgrade sbf tests to use bpf loader v3 (solana-labs#34691)
8869d0c 
* update sbf test to use bpf_loader v2

* update test_program_sbf_invoke_sanity test

* update test bpf program owner

* update test_program_sbf_invoke_upgradeable_via_cpi

* update test_program_sbf_disguised_as_sbf_loader

* update test_program_reads_from_program_account

* update test_program_sbf_program_id_spoofing

* update test_program_sbf_caller_has_access_to_cpi_program

* update 3 more tests

* fix program buffer size in minimul for rent exempt calculation

* more test updates

* more update

* more test updates

* comments

* undo c format

* typo

* add sol_alloc_free not deployable and deployable tests

* comments

* review feedback - move buffer_keypair and program_keypair inside callee
fn.

* more refactor

* delete sof_alloc_free_syscall enabled tests

* revert lamport change

---------

Co-authored-by: HaoranYi <haoran.yi@solana.com>
@tao-stones
remove old comment (solana-labs#34775)
d0b793a
@dependabot
build(deps): bump base64 from 0.21.6 to 0.21.7 (solana-labs#34782)
256179a 
* build(deps): bump base64 from 0.21.6 to 0.21.7

Bumps [base64](https://github.com/marshallpierce/rust-base64) from 0.21.6 to 0.21.7.
- [Changelog](https://github.com/marshallpierce/rust-base64/blob/master/RELEASE-NOTES.md)
- [Commits](marshallpierce/rust-base64@v0.21.6...v0.21.7)

---
updated-dependencies:
- dependency-name: base64
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@dependabot
build(deps): bump smallvec from 1.11.2 to 1.12.0 (solana-labs#34784)
711215f 
* build(deps): bump smallvec from 1.11.2 to 1.12.0

Bumps [smallvec](https://github.com/servo/rust-smallvec) from 1.11.2 to 1.12.0.
- [Release notes](https://github.com/servo/rust-smallvec/releases)
- [Commits](servo/rust-smallvec@v1.11.2...v1.12.0)

---
updated-dependencies:
- dependency-name: smallvec
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@HaoranYi
fix buffer size for updateable program buffer rent exempt fee calcula…
258c920 
…tion (solana-labs#34781)

fix buffer size for updateable program buffer rent exempt fee
calculation

Co-authored-by: HaoranYi <haoran.yi@solana.com>
@yihau
ci: use openssl 3.1.1 for Windows build (solana-labs#34795)
0e90e98
@yhchiang-sol
[TieredStorage] Include executable field into AccountMetaFlags (solan…
3fa44e6 
…a-labs#34724)

#### Problem
Before we have fully switched to the new way to determine whether
an account is executable, we still need a bit for th executable flag at
this moment in the TieredStorage as well as for backward compatibility
in case we want to revert it back.

#### Summary of Changes
This PR adds the executable flag into AccountMetaFlags.

#### Test Plan
Updated existing tests for AccountMetaFlags to cover executable flag.
@pgarg66
Do not reserve QUIC stream capacity for unstaked client on forward po…
9edf65b 
…rt (solana-labs#34779)
@drebaglioni
Update SECURITY.md (solana-labs#34800)
79b9999 
Added announcement of changes in bounty payouts AND added the high/low for each payout under the respective category
@dependabot
build(deps): bump enum-iterator from 1.4.1 to 1.5.0 (solana-labs#34791)
d025e71 
* build(deps): bump enum-iterator from 1.4.1 to 1.5.0

Bumps [enum-iterator](https://github.com/stephaneyfx/enum-iterator) from 1.4.1 to 1.5.0.
- [Commits](stephaneyfx/enum-iterator@1.4.1...1.5.0)

---
updated-dependencies:
- dependency-name: enum-iterator
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@dependabot
build(deps): bump bitflags from 2.4.1 to 2.4.2 (solana-labs#34806)
32f260b 
* build(deps): bump bitflags from 2.4.1 to 2.4.2

Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.4.1 to 2.4.2.
- [Release notes](https://github.com/bitflags/bitflags/releases)
- [Changelog](https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md)
- [Commits](bitflags/bitflags@2.4.1...2.4.2)

---
updated-dependencies:
- dependency-name: bitflags
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@brooksprumo
Removes unused snapshot errors (solana-labs#34812)
d878899
@behzadnouri
adds get_proof_offset for Merkle shreds (solana-labs#34798)
586c794 
In preparation of adding chained Merkle shreds variant, the commit
reworks api for proof-offset within the shred binary.
@bw-solana
Shred Repair Request (solana-labs#34771)
8fe4f5d 
* shred repair admin rpc
@brooksprumo
deps: Upgrades h2 due to security advisory (solana-labs#34816)
0e8f2de
@t-nelson
sdk: add bounds check when instantiating Keypair from byte array (s…
6dbcdc0 
…olana-labs#34817)
@jstarry
Fix versioned message json deserialization (solana-labs#34808)
747df9c
Lichtso and others added 28 commits January 19, 2024 15:28
@Lichtso
Cleanup - feature gate of stop_truncating_strings_in_syscalls (sola…
8e5cf13 
…na-labs#34842)

Cleanup feature gate of stop_truncating_strings_in_syscalls.
@tao-stones
explicitly sets fee rate to zero for stake-accounts tests (solana-lab…
fc53fd9 
…s#34848)

explicitly sets fee rate to zero
@tao-stones
explicitly sets tests that does not handle transaction fee (solana-la…
a57d612 
…bs#34847)
@tao-stones
use intended lamports_per_signature for fee_structure (solana-labs#34845
32a3de0 
)

use intented lamports_per_signature for fee_struture, instead of using default
Bubble up genesis load errors instead of exiting (solana-labs#34851)
3dd3488 
The function open_genesis_config() performs several operations that
could fail. If any of these fail, the process exits immediately.

Instead of exiting immediately, bubble up the error and let the caller
decide the appropriate action. solana-validator and solana-ledger-tool
will functionally be unchanged, but this consolidates startup failures
for both of these processes.
@dependabot
build(deps): bump rayon from 1.8.0 to 1.8.1 (solana-labs#34826)
cd4a424 
* build(deps): bump rayon from 1.8.0 to 1.8.1

Bumps [rayon](https://github.com/rayon-rs/rayon) from 1.8.0 to 1.8.1.
- [Changelog](https://github.com/rayon-rs/rayon/blob/master/RELEASES.md)
- [Commits](rayon-rs/rayon@rayon-core-v1.8.0...rayon-core-v1.8.1)

---
updated-dependencies:
- dependency-name: rayon
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@dependabot
build(deps): bump js-sys from 0.3.66 to 0.3.67 (solana-labs#34783)
4650c8d 
* build(deps): bump js-sys from 0.3.66 to 0.3.67

Bumps [js-sys](https://github.com/rustwasm/wasm-bindgen) from 0.3.66 to 0.3.67.
- [Release notes](https://github.com/rustwasm/wasm-bindgen/releases)
- [Changelog](https://github.com/rustwasm/wasm-bindgen/blob/main/CHANGELOG.md)
- [Commits](https://github.com/rustwasm/wasm-bindgen/commits)

---
updated-dependencies:
- dependency-name: js-sys
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@dependabot
build(deps): bump wasm-bindgen from 0.2.89 to 0.2.90 (solana-labs#34790)
39687a0 
* build(deps): bump wasm-bindgen from 0.2.89 to 0.2.90

Bumps [wasm-bindgen](https://github.com/rustwasm/wasm-bindgen) from 0.2.89 to 0.2.90.
- [Release notes](https://github.com/rustwasm/wasm-bindgen/releases)
- [Changelog](https://github.com/rustwasm/wasm-bindgen/blob/main/CHANGELOG.md)
- [Commits](rustwasm/wasm-bindgen@0.2.89...0.2.90)

---
updated-dependencies:
- dependency-name: wasm-bindgen
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* [auto-commit] Update all Cargo lock files

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot-buildkite <dependabot-buildkite@noreply.solana.com>
@yhchiang-sol
[TieredStorage] Code refactoring for OwnersBlock (solana-labs#34854)
81b3210 
#### Problem
The OwnersBlockFormat is currently defined inside footer.rs
instead of inside owners.rs.  In addition, the implementation of
OwnersBlock doesn't honor OwnersBlockFormat.

#### Summary of Changes
This PR moves OwnersBlockFormat from footer.rs to owners.rs
and repurpose OwnersBlock as OwnersBlockFormat (just like
the IndexBlockFormat inside index.rs)

#### Test Plan
Existing unit-tests.
@brooksprumo
Gracefully handles errors when archiving snapshots (solana-labs#34856)
2b0b5ae
@brooksprumo
Returns ArchiveSnapshotPackageError from archive_snapshot_package() (s…
a915e2f 
…olana-labs#34855)
@nickfrosty
[docs] CI white spaces (solana-labs#34858)
17de7a3 
chore: whitespaces and formatting
@brooksprumo
Replaces fs-err for some snapshot errors (solana-labs#34837)
6835e10
@tao-stones
harden cli tests (solana-labs#34844)
acef7ba 
harden cli tests by setting up TestValidator correctly
@brooksprumo
Replaces fs-err in accounts-db (solana-labs#34860)
3eb06b4
@wen-coding
Add RestartHeaviestFork to Gossip (solana-labs#34161)
4a2871f 
* Add RestartHeaviestFork to Gossip.

* Add a test for out of bound value.

* Send observed_stake and total_epoch_stake in ResatartHeaviestFork.

* Remove total_epoch_stake from RestartHeaviestFork.

* Forgot to update ABI digest.

* Remove checking of whether stake is zero.

* Remove unnecessary new function and make new_rand pub(crate).
@brooksprumo
Replaces fs-err in tiered storage (solana-labs#34859)
3916c31
@samkim-crypto
[clap-v3-utils] Replace pubkeys_sigs_of with try_pubkeys_sigs_of (s…
c071cf5 
…olana-labs#34801)

* replace `pubkeys_sigs_of` with `try_pubkeys_sigs_of`

* propagate error from `try_pubkeys_sigs_of` to the caller
@behzadnouri
adds chained merkle shreds variant (solana-labs#34787)
9a520fd 
With the new chained variants, each Merkle shred will also embed the Merkle
root of the previous erasure batch.
@buffalojoec
bpf-loader-upgradeable: export get_program_data_address helper
5eca299
@buffalojoec
bank: refactor builtins to support disable feature IDs
3fa29ce
@buffalojoec
bank: add Builtin enum for setting up migrations
8dfd204
@buffalojoec
bank: init migrate_builtin module
cdf5e51
@buffalojoec
bank: migrate_builtin: add builtin migration configs
97e1e7e
@buffalojoec
bank: migrate_builtin: add bpf migration configs
7110f7b
@buffalojoec
bank: migrate_builtin: add bpf upgradeable migration configs
6d75247
@buffalojoec
bank: migrate_builtin: add bpf migration function
261ebcc
@buffalojoec
bank: migrate_builtin: add bpf upgradeable migration function
6b30c6c
buffalojoec pushed a commit that referenced this pull request Mar 5, 2024
@yihau @willhickey
[anza migration] ci (#5)
b0022d7 
* Update README.md

* ci: update CodeCov report link

* ci: update github pr link

* ci: rename secondary pipeline

* replace org name in .mergify

* update channel info link

* update dependabot pr link

* use anza docker image

* delete travis

---------

Co-authored-by: Will Hickey <will.hickey@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.