Introduce docker develop environment #101

widoz · 2020-01-02T16:26:24Z

Read DEVELOPERS.md for more information

To make it work properly I updated the dependencies too
Also to prevent woocommerce to create wp-content within the
root of the project an extra installer-disable was defined
in the composer.json

props @XedinUnknown

@XedinUnknown

Read DEVELOPERS.md for more informations To make it work properly I updated the dependencies too Also to prevent woocommerce to create `wp-content` within the root of the project an extra `installer-disable` was defined in the composer.json props @XedinUnknown

Nitpick-CI · 2020-01-02T16:26:29Z

docker/wp-config.php

+
+// ** MySQL settings ** //
+/** The name of the database for WordPress */
+define( 'DB_NAME', 'wordpress' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:30Z

docker/wp-config.php

+define( 'DB_NAME', 'wordpress' );
+
+/** MySQL database username */
+define( 'DB_USER', 'wordpress' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:31Z

docker/wp-config.php

+define( 'DB_USER', 'wordpress' );
+
+/** MySQL database password */
+define( 'DB_PASSWORD', 'wordpress' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:32Z

docker/wp-config.php

+define( 'DB_PASSWORD', 'wordpress' );
+
+/** MySQL hostname */
+define( 'DB_HOST', 'mariadb' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:33Z

docker/wp-config.php

+define( 'DB_HOST', 'mariadb' );
+
+/** Database Charset to use in creating database tables. */
+define( 'DB_CHARSET', 'utf8' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:34Z

docker/wp-config.php

+define( 'DB_CHARSET', 'utf8' );
+
+/** The Database Collate type. Don't change this if in doubt. */
+define( 'DB_COLLATE', '' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:35Z

docker/wp-config.php

+ *
+ * @since 2.6.0
+ */
+define( 'AUTH_KEY',          'VZyXJ<Tl/+Mg]8HBx,PTW,5l|o;#vu[[e4FGFF|g]P^s4`0oiMw)qZo ~*$lV73q' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 10 found

Nitpick-CI · 2020-01-02T16:26:36Z

docker/wp-config.php

+ * @since 2.6.0
+ */
+define( 'AUTH_KEY',          'VZyXJ<Tl/+Mg]8HBx,PTW,5l|o;#vu[[e4FGFF|g]P^s4`0oiMw)qZo ~*$lV73q' );
+define( 'SECURE_AUTH_KEY',   '&xR- ]0G}(y-5Kb+D`:#%&c7NK]X;7,;_Wv)skugw~+U]nq`qey~OG|ZTxZ5c;=^' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 3 found

Nitpick-CI · 2020-01-02T16:26:37Z

docker/wp-config.php

+ */
+define( 'AUTH_KEY',          'VZyXJ<Tl/+Mg]8HBx,PTW,5l|o;#vu[[e4FGFF|g]P^s4`0oiMw)qZo ~*$lV73q' );
+define( 'SECURE_AUTH_KEY',   '&xR- ]0G}(y-5Kb+D`:#%&c7NK]X;7,;_Wv)skugw~+U]nq`qey~OG|ZTxZ5c;=^' );
+define( 'LOGGED_IN_KEY',     'mO*CN/~&]y&A*3:$qfGM3Km/)?_6q!ph*znCSnWULl$vQ)exEC(bQ$|RNU1i{ 0w' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 5 found

Nitpick-CI · 2020-01-02T16:26:38Z

docker/wp-config.php

+define( 'AUTH_KEY',          'VZyXJ<Tl/+Mg]8HBx,PTW,5l|o;#vu[[e4FGFF|g]P^s4`0oiMw)qZo ~*$lV73q' );
+define( 'SECURE_AUTH_KEY',   '&xR- ]0G}(y-5Kb+D`:#%&c7NK]X;7,;_Wv)skugw~+U]nq`qey~OG|ZTxZ5c;=^' );
+define( 'LOGGED_IN_KEY',     'mO*CN/~&]y&A*3:$qfGM3Km/)?_6q!ph*znCSnWULl$vQ)exEC(bQ$|RNU1i{ 0w' );
+define( 'NONCE_KEY',         'YafY sgP+RAo~:0Lj#Rf$gP(i01N<:fI&ombS !| FfF@rAR%r,|RLos2nKxeq~E' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 9 found

Nitpick-CI · 2020-01-02T16:26:39Z

docker/wp-config.php

+define( 'SECURE_AUTH_KEY',   '&xR- ]0G}(y-5Kb+D`:#%&c7NK]X;7,;_Wv)skugw~+U]nq`qey~OG|ZTxZ5c;=^' );
+define( 'LOGGED_IN_KEY',     'mO*CN/~&]y&A*3:$qfGM3Km/)?_6q!ph*znCSnWULl$vQ)exEC(bQ$|RNU1i{ 0w' );
+define( 'NONCE_KEY',         'YafY sgP+RAo~:0Lj#Rf$gP(i01N<:fI&ombS !| FfF@rAR%r,|RLos2nKxeq~E' );
+define( 'AUTH_SALT',         'rcRtXE::ax>_[{V:LR^WJzo juXti*q}A(!:)c4yi!U%C8oK/Z!A;p30l?LW+*8A' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 9 found

Nitpick-CI · 2020-01-02T16:26:40Z

docker/wp-config.php

+define( 'LOGGED_IN_KEY',     'mO*CN/~&]y&A*3:$qfGM3Km/)?_6q!ph*znCSnWULl$vQ)exEC(bQ$|RNU1i{ 0w' );
+define( 'NONCE_KEY',         'YafY sgP+RAo~:0Lj#Rf$gP(i01N<:fI&ombS !| FfF@rAR%r,|RLos2nKxeq~E' );
+define( 'AUTH_SALT',         'rcRtXE::ax>_[{V:LR^WJzo juXti*q}A(!:)c4yi!U%C8oK/Z!A;p30l?LW+*8A' );
+define( 'SECURE_AUTH_SALT',  '3[qjnu<bnz|sEJLtR#}0n^VEf ^]rXcA[hRa2VDitLhsng>m$jNG|=uy{1x29J_x' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 2 found

Nitpick-CI · 2020-01-02T16:26:41Z

docker/wp-config.php

+define( 'NONCE_KEY',         'YafY sgP+RAo~:0Lj#Rf$gP(i01N<:fI&ombS !| FfF@rAR%r,|RLos2nKxeq~E' );
+define( 'AUTH_SALT',         'rcRtXE::ax>_[{V:LR^WJzo juXti*q}A(!:)c4yi!U%C8oK/Z!A;p30l?LW+*8A' );
+define( 'SECURE_AUTH_SALT',  '3[qjnu<bnz|sEJLtR#}0n^VEf ^]rXcA[hRa2VDitLhsng>m$jNG|=uy{1x29J_x' );
+define( 'LOGGED_IN_SALT',    'Z}FU-B#c6W=l$WQ0Jw#(BRzDc@*/~LZxZ1;;*^ODa,Z>`r%<FuHmj_gyLepSn@V/' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 4 found

Nitpick-CI · 2020-01-02T16:26:42Z

docker/wp-config.php

+define( 'AUTH_SALT',         'rcRtXE::ax>_[{V:LR^WJzo juXti*q}A(!:)c4yi!U%C8oK/Z!A;p30l?LW+*8A' );
+define( 'SECURE_AUTH_SALT',  '3[qjnu<bnz|sEJLtR#}0n^VEf ^]rXcA[hRa2VDitLhsng>m$jNG|=uy{1x29J_x' );
+define( 'LOGGED_IN_SALT',    'Z}FU-B#c6W=l$WQ0Jw#(BRzDc@*/~LZxZ1;;*^ODa,Z>`r%<FuHmj_gyLepSn@V/' );
+define( 'NONCE_SALT',        'j_1pqvHVGF?6Ya[UX^O6efup}yU;sCbT%`dOEI@=Wv;faF5BuM1fwB64(Q*IDuA$' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Expected 1 space after comma in function call; 8 found

Nitpick-CI · 2020-01-02T16:26:42Z

docker/wp-config.php

+define( 'SECURE_AUTH_SALT',  '3[qjnu<bnz|sEJLtR#}0n^VEf ^]rXcA[hRa2VDitLhsng>m$jNG|=uy{1x29J_x' );
+define( 'LOGGED_IN_SALT',    'Z}FU-B#c6W=l$WQ0Jw#(BRzDc@*/~LZxZ1;;*^ODa,Z>`r%<FuHmj_gyLepSn@V/' );
+define( 'NONCE_SALT',        'j_1pqvHVGF?6Ya[UX^O6efup}yU;sCbT%`dOEI@=Wv;faF5BuM1fwB64(Q*IDuA$' );
+define( 'WP_CACHE_KEY_SALT', ' yPByarc]!MHyu4S|HfR?oat*d$Umt)/XHUh_K,l%mJ^UT$DYy t@X}i,/j3lhv:' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:43Z

docker/wp-config.php

+ */
+$table_prefix = 'wp_';
+
+define( 'WP_ALLOW_MULTISITE', true );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:44Z

docker/wp-config.php

+$table_prefix = 'wp_';
+
+define( 'WP_ALLOW_MULTISITE', true );
+define( 'MULTISITE', true );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:45Z

docker/wp-config.php

+
+define( 'WP_ALLOW_MULTISITE', true );
+define( 'MULTISITE', true );
+define( 'SUBDOMAIN_INSTALL', false );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:46Z

docker/wp-config.php

+define( 'MULTISITE', true );
+define( 'SUBDOMAIN_INSTALL', false );
+$base = '/';
+define( 'DOMAIN_CURRENT_SITE', 'multisite-global-media.docker' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:46Z

docker/wp-config.php

+define( 'SUBDOMAIN_INSTALL', false );
+$base = '/';
+define( 'DOMAIN_CURRENT_SITE', 'multisite-global-media.docker' );
+define( 'PATH_CURRENT_SITE', '/' );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:48Z

docker/wp-config.php

+$base = '/';
+define( 'DOMAIN_CURRENT_SITE', 'multisite-global-media.docker' );
+define( 'PATH_CURRENT_SITE', '/' );
+define( 'SITE_ID_CURRENT_SITE', 1 );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:48Z

docker/wp-config.php

+define( 'DOMAIN_CURRENT_SITE', 'multisite-global-media.docker' );
+define( 'PATH_CURRENT_SITE', '/' );
+define( 'SITE_ID_CURRENT_SITE', 1 );
+define( 'BLOG_ID_CURRENT_SITE', 1 );


Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:49Z

docker/wp-config.php

+/* That's all, stop editing! Happy blogging. */
+
+/** Absolute path to the WordPress directory. */
+if ( ! defined( 'ABSPATH' ) )


Inline control structures are not allowed

Expected 0 spaces after opening bracket; 1 found

Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

Nitpick-CI · 2020-01-02T16:26:50Z

docker/wp-config.php

+
+/** Absolute path to the WordPress directory. */
+if ( ! defined( 'ABSPATH' ) )
+	define( 'ABSPATH', dirname( __FILE__ ) . '/' );


Spaces must be used to indent lines; tabs are not allowed

Space after opening parenthesis of function call prohibited

Expected 0 spaces before closing bracket; 1 found

widoz · 2020-01-02T16:27:41Z

@bueltge the docker/wp-config.php is autogenerated, could we remove this file from being linted by Nitpick-CI ?

bueltge · 2020-01-03T12:39:16Z

@widoz Should we remove Nitpick-CI? I don't use it on other repositories and the hints here are not helpful. But done via 3235425

widoz · 2020-01-03T14:05:37Z

@bueltge Ok for remove it, phpcs is running on CI and for me that's ok

Nitpick-CI reviewed Jan 2, 2020

View reviewed changes

widoz requested a review from bueltge January 2, 2020 21:20

bueltge approved these changes Jan 3, 2020

View reviewed changes

bueltge merged commit b3d3d75 into master Jan 3, 2020

bueltge deleted the feature/introduce-docker branch January 3, 2020 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce docker develop environment #101

Introduce docker develop environment #101

widoz commented Jan 2, 2020 •

edited

Loading

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

Nitpick-CI Jan 2, 2020

widoz commented Jan 2, 2020

bueltge commented Jan 3, 2020 •

edited

Loading

widoz commented Jan 3, 2020

Introduce docker develop environment #101

Introduce docker develop environment #101

Conversation

widoz commented Jan 2, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

widoz commented Jan 2, 2020

bueltge commented Jan 3, 2020 • edited Loading

widoz commented Jan 3, 2020

widoz commented Jan 2, 2020 •

edited

Loading

bueltge commented Jan 3, 2020 •

edited

Loading