-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i3fyra] Manual/Automatic initialization of I3FYRA_WS is broken #180
Comments
@sdgoodrick thanks for reporting this. Please let me know if you find something, i will look in to it myself, if i can replicate the issue. To me it look like the error, ( |
aha! |
The workspace should be the name of i3fyra workspace, which if not already declared is the currently active workspace. Can you paste the output you get from the command One thing that could be a dirt-hack quick fix for you, is to set the environment variable I3FYRA_WS. |
I'm sorry, it seems I turned off github email notifications while working at my previous job, lol. Thank you for your response! I just reinstalled i3ass with a clean checkout. output of i3list[AWC]=94277602805984 # Active Window con_id
i3list[AWF]=0 # Active Window floating
i3list[AWI]=31457285 # Active Window id
i3list[AWW]=1920 # Active Window width
i3list[AWH]=1068 # Active Window height
i3list[AWX]=0 # Active Window x position
i3list[AWY]=12 # Active Window y position
i3list[AWB]=22 # Active Window titlebar height
i3list[ATX]=0 # Active Window tab x postion
i3list[ATW]=1920 # Active Window tab width
i3list[ABW]=1 # Active Window border width
i3list[APA]=94277601191360 # Active Window parent ID
i3list[WAI]=94277601191360 # Active Workspace con_id
i3list[WAX]=0 # Active Workspace x position
i3list[WAY]=34 # Active Workspace y position
i3list[WAW]=1920 # Active Workspace width
i3list[WAH]=1046 # Active Workspace height
i3list[WAN]="zen" # Active Workspace name
i3list[WSA]=-1 # Active Workspace number
i3list[TWC]=94277602805984 # Target Window con_id
i3list[TWF]=0 # Target Window Floating
i3list[TWI]=31457285 # Target Window id
i3list[TWW]=1920 # Target Window width
i3list[TWH]=1068 # Target Window height
i3list[TWX]=0 # Target Window x position
i3list[TWY]=12 # Target Window y position
i3list[TWB]=22 # Target Window titlebar height
i3list[TTX]=0 # Target Window tab x postion
i3list[TTW]=1920 # Target Window tab width
i3list[TBW]=1 # Target Window border width
i3list[TPA]=94277601191360 # Target Window parent ID
i3list[WTI]=94277601191360 # Target Workspace con_id
i3list[WTX]=0 # Target Workspace X poistion
i3list[WTY]=34 # Target Workspace Y position
i3list[WTW]=1920 # Target Workspace Width
i3list[WTH]=1046 # Target Workspace Height
i3list[WTN]="zen" # Target Workspace name
i3list[WST]=-1 # Target Workspace Number
i3list[RID]=94277601074880 # root container id
i3list[SUS]= # containers matching all criteria output of \ I get a similar error as in the OP when I run f virtual_position(A)
f container_show(A)
f container_create(A)
m [con_id=94277601194976] floating disable, move --no-auto-back-and-forth to workspace
m [con_id=94277601194976] split h, layout tabbed, focus, focus parent
m mark i34A
f family_show(AC A)
m [con_mark=i34A] move to mark i34XAC
m [con_mark=i34A] swap mark i34C
m [con_id=94277601194976] focus
f CLEANUP()
ERROR: Your command: [con_id=94277601194976] floating disable, move --no-auto-back-and-forth to workspace ;[con_id=94277601194976] split h, layout tabbed, focus, focus parent;mark i34A;[con_mark=i34A] move to mark i34XAC;[con_mark=i34A] swap mark i34C;[con_id=94277601194976] focus
ERROR: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ERROR: Expected one of these tokens: 'to ', 'next_on_output', 'prev_on_output', 'next', 'prev', 'current', 'back_and_forth', 'number', <string>
[{"success":true},{"success":false,"parse_error":true,"error":"Expected one of these tokens: 'to ', 'next_on_output', 'prev_on_output', 'next', 'prev', 'current', 'back_and_forth', 'number', <string>","input":" [con_id=94277601194976] floating disable, move --no-auto-back-and-forth to workspace ;[con_id=94277601194976] split h, layout tabbed, focus, focus parent;mark i34A;[con_mark=i34A] move to mark i34XAC;[con_mark=i34A] swap mark i34C;[con_id=94277601194976] focus","errorposition":"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^"}]
|
Here's something, interesting: after rebooting and running i3list[AWC]=94091642360016 # Active Window con_id
i3list[AWF]=0 # Active Window floating
i3list[AWI]=16777222 # Active Window id
i3list[AWW]=1920 # Active Window width
i3list[AWH]=1080 # Active Window height
i3list[AWX]=0 # Active Window x position
i3list[AWY]=0 # Active Window y position
i3list[AWB]=22 # Active Window titlebar height
i3list[ATX]=0 # Active Window tab x postion
i3list[ATW]=1920 # Active Window tab width
i3list[ABW]=1 # Active Window border width
i3list[APA]=94091642363568 # Active Window parent ID
i3list[AWP]=A # Active Window parent
i3list[AFT]=B # Active Window twin
i3list[AFC]=D # Active Window cousin
i3list[AFS]=C # Active Window sibling
i3list[AFF]=AC # Active Window family
i3list[AFO]=BD # Active Window relatives
i3list[WAI]=94091642358160 # Active Workspace con_id
i3list[WAX]=0 # Active Workspace x position
i3list[WAY]=0 # Active Workspace y position
i3list[WAW]=1920 # Active Workspace width
i3list[WAH]=1080 # Active Workspace height
i3list[WAN]="zen" # Active Workspace name
i3list[WSA]=-1 # Active Workspace number
i3list[TWC]=94091642360016 # Target Window con_id
i3list[TWF]=0 # Target Window Floating
i3list[TWI]=16777222 # Target Window id
i3list[TWW]=1920 # Target Window width
i3list[TWH]=1080 # Target Window height
i3list[TWX]=0 # Target Window x position
i3list[TWY]=0 # Target Window y position
i3list[TWB]=22 # Target Window titlebar height
i3list[TTX]=0 # Target Window tab x postion
i3list[TTW]=1920 # Target Window tab width
i3list[TBW]=1 # Target Window border width
i3list[TPA]=94091642363568 # Target Window parent ID
i3list[TWP]=A # Target Window Parent container
i3list[TFT]=B # Target Window twin
i3list[TFC]=D # Target Window cousin
i3list[TFS]=C # Target Window sibling
i3list[TFF]=AC # Target Window family
i3list[TFO]=BD # Target Window relatives
i3list[WTI]=94091642358160 # Target Workspace con_id
i3list[WTX]=0 # Target Workspace X poistion
i3list[WTY]=0 # Target Workspace Y position
i3list[WTW]=1920 # Target Workspace Width
i3list[WTH]=1080 # Target Workspace Height
i3list[WTN]="zen" # Target Workspace name
i3list[WST]=-1 # Target Workspace Number
i3list[WFI]=94091642358160 # i3fyra Workspace con_id
i3list[WFX]=0 # i3fyra Workspace X position
i3list[WFY]=0 # i3fyra Workspace Y position
i3list[WFW]=1920 # i3fyra Workspace Width
i3list[WFH]=1080 # i3fyra Workspace Height
i3list[WFN]="zen" # i3fyra Workspace name
i3list[WSF]=-1 # i3fyra Workspace Number
i3list[CAL]="tabbed" # Container A Layout
i3list[CAW]=-1 # Container A Workspace number
i3list[CAN]="zen" # Container A Workspace name
i3list[CAF]=94091642360016 # Container A Focused container id
i3list[LVI]=A # Visible i3fyra containers
i3list[LHI]= # Hidden i3fyra containers
i3list[LEX]=A # Existing containers (LVI+LHI)
i3list[SAB]=0 # Current split: AB
i3list[SAC]=0 # Current split: AC
i3list[XAC]=-1 # family AC workspace number
i3list[LAL]=ACBD # All containers in family order
i3list[NAB]="zen" # family AB workspace name
i3list[NAC]="zen" # family AC workspace name
i3list[ORI]=horizontal # i3fyra orientation
i3list[MAB]=0 # Stored split: AB
i3list[XAB]=-1 # family AB workspace number
i3list[RID]=94091642342288 # root container id
i3list[SUS]= # containers matching all criteria and now i3fyra almost works? I get a new error from virtual_position(A)
f container_show(A)
f container_create(A)
m [con_id=94091642360016] floating disable, move --no-auto-back-and-forth to workspace zen
m [con_mark=i34XAB] split h
m [con_id=94091642360016] move to mark i34XAB
m [con_id=94091642360016] split h, layout tabbed, focus, focus parent
m mark i34A
f family_show(AC A)
m [con_mark=i34A] move to mark i34XAC
m [con_mark=i34A] swap mark i34C
m [con_id=94091642360016] focus
f CLEANUP()
ERROR: Could not find container for mark = i34C
[{"success":true},{"success":true},{"success":true},{"success":true},{"success":true},{"success":true},{"success":true},{"success":true},{"success":true},{"success":true},{"success":false,"error":"Could not find container for mark = i34C"},{"success":true}]
|
Great info. One thing i think might be related is that in your second i3list as you noticed, "zen" is your fyra workspace, and I assume this is not what you expect. I believe this is due to a strange thing with i3, the first keybinding to a a workspace will define the starting workspace. So try adding a keybinding like this: |
I have been having similar errors before; they were i3fyra errors, however, called through i3king rules. It did denote the same i3-msg error message though. I have some observations about i3zen/zenmode though:
tl;dr bottom line
|
Big thanks, this is very good info! I would really like to find and squash these bug(s?). First thing that is needed is to identify the issues, and find a way to replicate them. And create separate "tickets/issues" for them here on github. I know that one issue, is that the example config file in the wiki has There also seem to be an issue with setting the i3fyra workspace, and that i3fyra is (in @sdgoodrick first example) fails because it uses Related to this is @1ntronaut All in all, i think we can group these issues into one, "Manual/Automatic setting which workspace is for i3fyra", I will re-title this issue for that.
Not sure if you have a typo there, but Nevertheless, i should add a test in i3fyra and error out if arguments are passed to
This is actually something I have noticed myself, I will create a new issue for it.
There are at least three issues here. The first probably relates to the ones described above about i3fyra workspace not being set correctly, but i will create a new issue called "windows spawned from config file, is not placed in i3fyra layout". And one issue that could be called "i3fyra --move CONTAINER, does not create containers", if you agree, create that issue.
This is a good goalpost for all of these issues, when they are resolved the ordering should not matter. This might also indicate that there is a race condition (where i3fyra is called without I3FYRA_WS being set, multiple time). I will keep it in mind, but let's wait making it a separate issue.
Yeah, there is something here and I suspect it boils down to the same thing, a combination of I3FYRA_WS not being set and a race condition from i3fyra trying to automatically set it.
It was a bit brutal of me to completely replace/remove i3menu like I did, but, since i3menu now is independent, the obvious fix would be to resurrect the old i3menu, make it a separate repo: i3menu-rofi , doing this will let you (and others, who can't shake rofi) have an up to date i3ass. I will do that, i3menu-rofi will be more or less un-maintained (at least by me) and not recommended, but it can be a thing, sorry that i removed it like that. |
I am not sure whether or not it's a typo or a brainfart on my part, probably both. Regardless, you are definitely right:
.... alright, sorry, running out of time here ; will return later. |
The workspace name is automatically set by i3fyra, and this is done before any i3fyra containers exist. i3list only printed i3fyra related stuff if the ID of the i3fyra workspace was known, this resulted in a issue (#180) where i3fyra couldnt get initialized properly if the user wasnt on the same workspace as the i3fyra workspace name. Other useful info (like stored splitsizes) where also hidden without ID related was also that i only made sure double quotes where added to i3fyra_ws when the ws name was fetched automatically.
I made some good progress on this, and found a obvious bug in i3list which made it so that the fyra workspace name was only printed when it was the active workspace. I also made sure that I3FYRA_WS always gets stored with doublequotes, which may or may not have been the reason it was problematic before. (i saw that i did this when the workspace was set automatically to the active workspace name) |
@budRich
@budRich Suppose you could 'support' unmaintained i3menu-rofi (at least until it breaks compatibility) and just coin it a deprecated/legacy feature? Maybe introduce another env variable? or command line option? to have i3menu bypass default use of 'dmenu' and use 'rofi' ? (e.g. (((-- optional semi-offtopic read: |
I have been working long days this whole year, which is one, (but not the main), reason i haven't made youtubes in a while. But this week i started my four week vacation, and have some time to tidy up f.i. i3ass I am actually in the process of resurrecting the budrich blog, i found the original markdown, i will update and publish soon. But it is just a rewrite of what already been said on ubuntu forums (links still works!) https://askubuntu.com/questions/210283/how-to-use-fixedsys-in-the-gnome-terminal-or-wherever-monospaced-fonts-are-requ
No, but yes, it will be something like you say. but Neither i3menu(-dmenu) or i3menu-rofi will be included in i3ass again. both will be available as packages on AUR, and in conflict with each other. Only i3menu(-dmenu) will be an optional package for i3ass. So users can always have i3ass installed up to date, and chose if and which i3menu to install. I will maybe try to see (in rofi and i3 community) if someone wants to adopt the i3menu-rofi repository (but i doubt that). i will accept PRs but will not try to fix any issues in i3menu-rofi myself.
you and @sdgoodrick have helped out a lot here, and just knowing that there actually exist more than 1 user (bud), made me motivated to do stuff.
❤️ |
I had i3fyra working, but after rebooting my PC (no update!), I am getting some error that is not particularly descriptive. I am on i3 version 4.22; i3fyra version 1.35
I will look through the script myself and try to debug this, but any insight would be appreciated
The text was updated successfully, but these errors were encountered: