Update MANIFEST.in to enable a testable sdist #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bskinn
added
type: enhancement ✨
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 743 743
=========================================
Hits 743 743
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bskinn
force-pushed
the
update-manifest
branch
from
f643034 to
9e22759
Compare
(1) Adding to a temporary first stage for now, for faster testing. Later to be moved to the aux tests at the end of the pipeline. (2) Remove 'soi' dir & change to correct dir for steps Helps to have cwd in the right place for things to, y'know, work. (3) Escape those dollar signs (4) Remove up-front docs build & req'ts install For a build, it *should* be enough just to install 'build'? (5) Unescape $s and turn 's to "s Nope, wasn't the dollar signs. Something weird in how the single quotes were interacting with Pipelines's string handling, maybe? (6) Add a debugging step (7) Refine the regex for finding the sdist dir
Long enough that it's worth the extra real estate in the repo root dir, I think.
bskinn
force-pushed
the
update-manifest
branch
from
9e22759 to
fd59f8f
Compare
Always packaging UNIX-style line-endings this way, when creating an sdist. Should be the fix for: #264 (comment)
Fixtures needed explicit updating to account for the fact that tests/resource/objects_attrs.txt is now checked out with Unix newlines even on Windows.
Behavior change of str/Enum mixin means that I *have* to include the explicit .value. This will affect the pent codebase, too.
Again, to account for bugfix/behavior change in 3.11.
bskinn
force-pushed
the
update-manifest
branch
from
21f52e7 to
a967ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #264.
Whole bunch of stuff to make an sdist actually testable needs to be packaged.