Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flavour scripts don't work on non-persistent pots #238

Closed
grembo opened this issue Oct 27, 2022 · 0 comments · Fixed by #241
Closed

[BUG] Flavour scripts don't work on non-persistent pots #238

grembo opened this issue Oct 27, 2022 · 0 comments · Fixed by #241
Labels

Comments

@grembo
Copy link
Collaborator

grembo commented Oct 27, 2022

Describe the bug
When setting the persistent flag to OFF in a flavour (set-attribute -A persistent -V OFF), running the flavour script fails.

To Reproduce
Create a flavour that contains a file that contains set-attribute -A persistent -V OFF and has a trivial flavour script flavour.sh. Try to create a pot and see it fail.

Expected behavior
Creating the pot should work.

Additional context
This used to work, probably by accident, since we had various sleeps inside pots that would keep it alive long enough to launch a command.

Since we no longer have background sleeps to keep the pot alive, it shuts down. The work to properly lock start/stop might also contribute to this.

A clean solution could be to override flv_set_cmd temporarily and run the non-persistent pot once - alternatively, start could grow a special parameter we can use for this case.

The workaround is to not create non-persistent pots (in case they are non-persistent for use in nomad, pot prepare overrides the persistent flag anyway).

@grembo grembo added the bug label Oct 27, 2022
grembo added a commit to grembo/pot that referenced this issue Nov 6, 2022
grembo added a commit to grembo/pot that referenced this issue Nov 6, 2022
grembo added a commit to grembo/pot that referenced this issue Nov 6, 2022
grembo added a commit to grembo/pot that referenced this issue Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant