Allow building metal without documentation, examples and tests #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users including metal in their projects using CMake's ExternalProject_Add, FetchContent or a git submodule with `add_subdirectory` might not want to build the docs, examples or tests. In fact, they might not even have the dependencies (doxygen for docs, boost for examples), which causes CMake to print a warning even though it doesn't cause build failures. For such users metal now provides options METAL_BUILD_DOC, METAL_BUILD_TESTS and METAL_BUILD_EXAMPLES that are ON by default, but can be turned off by consumers.
|
Hey @Corristo, thanks for the patch, this seems reasonable to me. Tests seems to have failed due to transient issues with the workers, do you mind restarting the execution? |
|
@brunocodutra How do I do that? I've tried to follow https://help.github.com/en/actions/configuring-and-managing-workflows/managing-a-workflow-run#viewing-your-workflow-history but I don't have the re-run button. |
|
@Corristo when I attempt to retry it fails with some weird error I attributed to the fact this is a PR from a forked repo, no idea what's going on. I have no concerns though, as the original failure seems to be due to a timeout installing dependencies, so I'll merge manually. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users including metal in their projects using CMake's ExternalProject_Add,
FetchContent or a git submodule with
add_subdirectorymight not want tobuild the docs, examples or tests. In fact, they might not even have the
dependencies (doxygen for docs, boost for examples), which causes CMake to
print a warning even though it doesn't cause build failures.
For such users metal now provides options METAL_BUILD_DOC,
METAL_BUILD_TESTS and METAL_BUILD_EXAMPLES that are ON by default, but
can be turned off by consumers.