-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find relative path for process module #31
Conversation
Potential fix for browserify/browserify#675 and browserify/browserify#657 |
Thanks for the patch. I'm hesitant to merge something with so much custom path string arithmetic. Could this be rewritten to use |
@substack the reason for all the path string manipulation is that |
@substack any thoughts? |
@jkimbo you might want to use path.sep instead of hardcoding seperators |
I think #33 is a better solution so I'm closing this. |
fixed upstream in 3.46.1 by passing in the hash-mapped path into insert-module-globals manually |
Include
process\browser
module as a relative path instead of an absolute one to avoid having full system paths in bundles.