Requires only the necessary core_ext from active_support. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base.rb seem to only require the hash extension but was requiring the whole active_support/core_ext. That injected active_support/core_ext/object/json.rb in the call chain. When you have an object composed of other objects where the parent doesn't define :to_json it would completely ignore :to_json defined in the children, using active_support's instead.
brooklynDev
added a commit
that referenced
this pull request
Sep 22, 2014
Requires only the necessary core_ext from active_support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base.rb seem to only require the hash extension but was requiring the
whole active_support/core_ext. That injected
active_support/core_ext/object/json.rb in the call chain.
When you have an object composed of other objects where the parent
doesn't define :to_json it would completely ignore :to_json defined
in the children, using active_support's instead.