Tests fail under RSpec 3.2 due to Airborne#initialize needing to accept arguments #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I just upgraded RSpec on my local machine and sure enough the current version of |
brooklynDev
added a commit
that referenced
this pull request
Feb 26, 2015
Tests fail under RSpec 3.2 due to Airborne#initialize needing to accept arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the gem wasn't using the constructor arguments before, I've just altered StubHelper to accept splat arguments and then ignored them. This turns the test suite green, however long-term people might want to change this behaviour to something more contextual.