Replace Fixnum and Bignum with Integer

[mcasper]

Ruby 2.4 deprecated the use of both Fixnum and Bignum, instead
encouraging everyone to just use Integer, which is their superclass.

So, we can replace all instances of the two deprecated classes with just
Integer, silencing the warnings from this library when on Ruby 2.4.X.

It looks like this exact change has been opened twice, and then immediately closed out by the owners? Is there a reason for this?

https://bugs.ruby-lang.org/issues/12005

[coveralls]

Coverage decreased (-0.8%) to 98.171% when pulling ca8fe8d on mcasper:ruby-2-4-warnings into a55e8e2 on brooklynDev:master.

[coveralls]

Coverage increased (+0.004%) to 98.975% when pulling 3e5e598 on mcasper:ruby-2-4-warnings into a55e8e2 on brooklynDev:master.

[sethpollack]

Thanks for the PR, can you move the logic to a function and use if Integer == Fixnum instead of if RUBY_VERSION.match(/^2.4/)

[mcasper]

Hey @sethpollack! Happy to move it to a method, but won't using if Integer == Fixnum still cause the deprecation warning, since Fixnum will get evaluated in the Ruby 2.4 case?

[sethpollack]

I found the fix in rails, also I tested it and it works.

[mcasper]

Right, it works, but it still emits a deprecation warning. If you look at Rails master, you'll see they changed it to if 0.class == Integer

[coveralls]

Coverage increased (+0.007%) to 98.978% when pulling d86735f on mcasper:ruby-2-4-warnings into a55e8e2 on brooklynDev:master.

[mcasper]

Updated this to use if 0.class == Integer. (0's class is Fixnum prior to Ruby 2.4.0)

[coveralls]

Coverage increased (+0.005%) to 98.976% when pulling eef7105 on mcasper:ruby-2-4-warnings into a55e8e2 on brooklynDev:master.

[sethpollack]

Ok so lets go with 0.class == Integer

[sethpollack]

Perfect thanks!

[sethpollack]

Ok published the new version

[mcasper]

Awesome, thanks!

[sethpollack]

@mcasper
What do you think about using any?{|type| value.is_a?(type) instead. Then you can just use Integer and would never need Bignum/Fixnum.

[sethpollack]

I can push up the changes, just wanted to hear your thoughts?

[mcasper]

Hmm, but don't we need to keep Fixnum and Bignum around so we don't break Ruby 2.3 and lower functionality? If we can remove Fixnum and Bignum functionality from the lower versions, then let's just remove all this checking and put Integer everywhere

[sethpollack]

No in the lower versions Integer is the superclass of Fixnum and Bignum. For example:

> Fixnum.superclass
 => Integer

> 1.class
 => Fixnum

> 1.is_a?(Integer)
 => true

So I'm suggesting only using Integer and just changing the expect_type logic to use is_a? instead of comparing the classes.

[sethpollack]

Ok, I pushed up the changes.

[mcasper]

Ohhh sorry, I see what you mean now. Looks great!