Check whether first_colour is set before using it as foreground color #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for conkyweb canceled.
|
Caellian
added
enhancement
Caellian
approved these changes
Feb 3, 2025
Comment on lines
-1401
to
+1404
| // Set the foreground colour to the first colour, ensures the scale text is always drawn in the same colour | ||
| set_foreground_color(current->first_colour); | ||
| if (current->colours_set) { | ||
| // Set the foreground colour to the first colour, ensures the scale text is always drawn in the same colour | ||
| set_foreground_color(current->first_colour); | ||
| } |
|
@livanh thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
doc/has been updatedDescription
For several months now, the first color of a graph's gradient is also being used as the foreground color, but without properly checking whether the gradient colors are actually set. If they are not, the scale text of the graph is set to black instead of the default color:
With this change, the scale text correctly follows the default color:
(I don't think the documentation needs an update, but I will do it if requested)