[iss 429] bug fix for Shear.TimeOfDay #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rach185, This all looks ok. Is your intention for this to be a hotfix and to do another release of the library? You have the pull request to merge straight into master and not the usual dev branch. Cheers, |
|
Merged as a hotfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
plot_shear_time_of_dayfunction in plot.py crashes sometimes. The real issue behind this fault is unclear - it looks to be a jupyter notebook issue. I think it's easier to update theplot_shear_time_of_dayfunction to be more robust. The fix involves changing how the hour axis is is defined.