Set timezone from initializer Ruby DSL #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushn21
force-pushed
the
fix-timezone
branch
2 times, most recently
from
6e39cf0 to
8b0258f
Compare
ayushn21
force-pushed
the
fix-timezone
branch
from
8b0258f to
4ff86c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
While running tests for the
bridgetown-sitemapplugin, I found that the timezone wasn't being set if it was defined ONLY in the Ruby initializers file. I have no idea why this wasn't a problem yesterday, but it is today.Upon investigation, I found that the timezone is set as an environment variable but this only happens when the configuration object is instantiated. The initializers run after the object is instantiated. Hence, the timezone value was set in the configuration object, but not in the environment variable meaning it wasn't used in the build.
I've added a
timezonemethod to the DSL which sets this value.