Parse using JSON.parse for more resilient parsing #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAMLParser (which is backed by Ruby's YAML parser) appears to have a problem with larger json files. On one source file, I ran into `Error: YAML Exception reading ../src/_data/posts.json: control characters are not allowed at line 1 column 1`. But when patched to use JSON.parse, it works well. No tests are needed because it's hit heavily throughout the test suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 🐛 bug fix.
Summary
YAMLParser (which is backed by Ruby's YAML parser) appears to have a problem with larger json files.
On one source file, I ran into
Error: YAML Exception reading ../src/_data/posts.json: control characters are not allowed at line 1 column 1. But when patched to use JSON.parse, it works well.No tests are needed because it's hit heavily throughout the test suite
Context
A project that I have has a rather large json file as it's data source (2.3M JSON file) and it appears that these larger files have some issues being parsed by the ruby YAML parser (aka.
YAML.load) which can also parse json. This data file has been validated withjqandJSON.parse.