Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence keyword arguments warning in ruby 2.7 #615

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Silence keyword arguments warning in ruby 2.7 #615

merged 1 commit into from
Aug 24, 2022

Conversation

sandstrom
Copy link
Contributor

@sandstrom sandstrom commented Aug 24, 2022

Silence a warning under ruby 2.7.

site/.direnv/ruby/gems/bridgetown-core-1.1.0/lib/bridgetown-core/helpers.rb:115: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
site/.direnv/ruby/gems/i18n-1.12.0/lib/i18n.rb:210: warning: The called method `t' is defined here

Here is a similar fix in Rails, a while ago:

rails/rails@adef632#diff-9c5e802c729a438537b41a02f0b08eb594855d8bebcd0ff2e3452fc6a999375d

For reference, here is the issue in i18n gem (but I think this must be solved in this repo):
ruby-i18n/i18n#516


I've only tested this quickly on my machine, but I think it should work.

@sandstrom
Copy link
Contributor Author

@jaredcwhite Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants