Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Ruby front matter, template engine not working as a symbol #395

Closed
jaredcwhite opened this issue Sep 17, 2021 · 0 comments · Fixed by #396
Closed

In Ruby front matter, template engine not working as a symbol #395

jaredcwhite opened this issue Sep 17, 2021 · 0 comments · Fixed by #396
Labels
bug Something isn't working
Milestone
1.0

Comments

@jaredcwhite
Copy link
Member

jaredcwhite commented Sep 17, 2021 •
edited
Loading

template_engine: :erb doesn't work within the ERB template converter, but template_engine: "erb" does work — we'll need to add a to_s in the appropriate locations. (e.g.

bridgetown/bridgetown-core/lib/bridgetown-core/converters/erb_templates.rb

Line 134 in 0b6b3fd

if convertible.data[:template_engine] == "erb" ||

@jaredcwhite jaredcwhite added the bug Something isn't working label Sep 17, 2021
@JuanVqz JuanVqz mentioned this issue Sep 21, 2021
Merged
@jaredcwhite jaredcwhite added this to the 1.0 milestone Sep 24, 2021
jaredcwhite pushed a commit that referenced this issue Oct 18, 2021
Allow to use symbols on the front matter (#396)
71a7b23 
* Allow to use symbols on the front matter

Fixes #395

* Change template_engine to string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Allow to use symbols on the front matter JuanVqz/bridgetown
1 participant
@jaredcwhite