-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the comment type in features!
's matcher
#1470
Conversation
This should also be reported to https://github.com/rust-lang/rust/ as a nightly regression. |
see briansmith#1470 for details
Is the plan to have this merged and released no matter what |
This should be merged anyway, even if the rustc regression were to be fixed. See rust-lang/rust#95390 (comment) |
Even though the rust-lang/rust change was made, which makes this non-critical, I've approved this change and I'll merge it as soon as CI/CD psases. |
Codecov Report
@@ Coverage Diff @@
## main #1470 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 129 129
Lines 18363 18363
Branches 195 195
=======================================
Hits 16870 16870
+ Misses 1461 1460 -1
- Partials 32 33 +1
Continue to review full report at Codecov.
|
This might not help to resolve #1469.
No idea for me :)
Edit: please ignore what I explained here before.