Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the comment type in features!'s matcher #1470

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

zjp-CN
Copy link
Contributor

@zjp-CN zjp-CN commented Mar 24, 2022

This might not help to resolve #1469.

No idea for me :)

Edit: please ignore what I explained here before.

@sdroege
Copy link

sdroege commented Mar 24, 2022

It's weird stable Rust lets the original code pass.

This should also be reported to https://github.com/rust-lang/rust/ as a nightly regression.

@zjp-CN
Copy link
Contributor Author

zjp-CN commented Mar 24, 2022

@sdroege Yeah, it's already there.

@faern
Copy link

faern commented Mar 25, 2022

Is the plan to have this merged and released no matter what rustc decides to do? It feels like the comment in question should not be a doc comment.

@paolobarbolini
Copy link

This should be merged anyway, even if the rustc regression were to be fixed. See rust-lang/rust#95390 (comment)

@briansmith
Copy link
Owner

Even though the rust-lang/rust change was made, which makes this non-critical, I've approved this change and I'll merge it as soon as CI/CD psases.

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1470 (ea2a7a5) into main (32b2c6c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files         129      129           
  Lines       18363    18363           
  Branches      195      195           
=======================================
  Hits        16870    16870           
+ Misses       1461     1460    -1     
- Partials       32       33    +1     
Impacted Files Coverage Δ
src/cpu/arm.rs 91.66% <ø> (ø)
crypto/cpu-intel.c 70.49% <0.00%> (-6.56%) ⬇️
crypto/curve25519/curve25519.c 99.77% <0.00%> (+0.07%) ⬆️
crypto/poly1305/poly1305.c 98.95% <0.00%> (+0.52%) ⬆️
src/aead/less_safe_key.rs 96.89% <0.00%> (+0.77%) ⬆️
src/io/der_writer.rs 100.00% <0.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b2c6c...ea2a7a5. Read the comment docs.

@briansmith briansmith merged commit f7eea6d into briansmith:main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to compile ring under nightly Rust (1.61.0, 9f4dc0b4d 2022-03-23)
5 participants