-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ls: list file arguments in columns #967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Feb 26, 2025
- Test case: "perl ls spell ar ar ."
- The argument list is split into files and directories
- File arguments are listed first in multi-column output, followed by each directory argument
- Previously List() was called once per file argument; this was incorrect because List() is unable to format the arguments together in columns
- Fix this by preparing a sorted file list and attribute hash (containing stat() data), then calling List() once
- DirEntries() has to be called once per file, then the stat data returned is merged into a single hash
- Bump version
* Test case: "perl ls spell ar ar ." * The argument list is split into files and directories * File arguments are listed first in multi-column output, followed by each directory argument * Previously List() was called once per file argument; this was incorrect because List() is unable to format the arguments together in columns * Fix this by preparing a sorted file list and attribute hash (containing stat() data), then calling List() once * DirEntries() has to be called once per file, then the stat data returned is merged into a single hash * Bump version
Pull Request Test Coverage Report for Build 13535065421Details
💛 - Coveralls |
changes: improve multi-columnar output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: ls
The ls program
Status: accepted
The fix is accepted
Type: bug
an existing feature does not work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.