Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uniq: get_numeric_arg() versus empty string #964

Merged
merged 1 commit into from
Feb 25, 2025
Merged

uniq: get_numeric_arg() versus empty string #964

merged 1 commit into from
Feb 25, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Feb 25, 2025

  • The uniq command expects a number argument to options -s and -f
  • Make $opt declaration clearer; it is not a parameter of get_numeric_arg()
  • Update validation to raise error for empty string (not a number)
  • Zero is allowed for -s and -f option arguments, so get_numeric_arg() allows it
  • Bump version
%perl uniq -f '' file
uniq: invalid number of fields to skip: `'
%perl uniq -s '' file
uniq: invalid number of bytes to skip: `'

@mknos
uniq: get_numeric_arg() versus empty string
00bf48e 
* The uniq command expects a number argument to options -s and -f
* Make $opt declaration clearer; it is not a parameter of get_numeric_arg()
* Update validation to raise error for empty string (not a number)
* Zero is allowed for -s and -f option arguments, so get_numeric_arg() allows it
* Bump version
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: uniq The uniq program labels Feb 25, 2025
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:53 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 25, 2025 03:54 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 25, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13513283887

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.349%
Totals Coverage Status
Change from base Build 13503527620: 0.0%
Covered Lines: 348
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy self-assigned this Feb 25, 2025
@briandfoy briandfoy merged commit dd06588 into briandfoy:master Feb 25, 2025
23 checks passed
@github-actions github-actions bot added the Status: accepted The fix is accepted label Feb 25, 2025
@briandfoy briandfoy removed the Priority: low get to this whenever label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: uniq The uniq program Status: accepted The fix is accepted Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy