Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: retire fisher_yates_shuffle() #896

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 3, 2025

  • Reduce code that needs to be maintained by using the shuffle() function from List::Util
  • Small declarations change: explicitly import getopts() function

* Reduce code that needs to be maintained by using the shuffle() function from List::Util
* Small declarations change: explicitly import getopts() function
@mknos mknos temporarily deployed to automated_testing January 3, 2025 00:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 00:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 00:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 00:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 00:29 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 00:29 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: fish The fish program labels Jan 3, 2025
@briandfoy briandfoy merged commit 62af3b7 into briandfoy:master Jan 3, 2025
21 of 22 checks passed
@briandfoy
Copy link
Owner

changes: use List::Util instead of implementing our own shuffle

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 3, 2025
@briandfoy briandfoy self-assigned this Jan 3, 2025
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:01 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:02 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:02 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 3, 2025

Pull Request Test Coverage Report for Build 12590737844

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%

Totals Coverage Status
Change from base Build 12578193049: -0.7%
Covered Lines: 350
Relevant Lines: 483

💛 - Coveralls

@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:03 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:04 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:05 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:06 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 3, 2025 02:08 — with GitHub Actions Inactive
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: fish The fish program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants