Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: simplify strmode() #889

Merged
merged 1 commit into from
Jan 1, 2025
Merged

ar: simplify strmode() #889

merged 1 commit into from
Jan 1, 2025

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 1, 2025

  • When running "ar -tv file.a", the file permissions of archive members are listed
  • Use the file mode number directly instead of splitting the input octal string and converting each part to a separate number
  • I tested that I still get the same mode string for an archive compared to binutils ar

@mknos
ar: simplify strmode()
f5bdfdf 
* When running "ar -tv file.a", the file permissions of archive members are listed
* Use the file mode number directly instead of splitting the input octal string and converting each part to a separate number
* I tested that I still get the same mode string for an archive compared to binutils ar
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Jan 1, 2025
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:07 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing January 1, 2025 02:08 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Jan 1, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12566145047

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.464%
Totals Coverage Status
Change from base Build 12398496491: 0.0%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy merged commit 6065ad9 into briandfoy:master Jan 1, 2025
23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 1, 2025
@briandfoy briandfoy self-assigned this Jan 1, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy