-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expr: improved parser #879
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Dec 17, 2024
- The old expression parser didn't work for some basic expressions I tested
- It was a bit confusing to debug the old code because everything happened in the one evaluate() function
- Replace the code with a parser based on the OpenBSD version
- Different operator priorities are delegated to different functions so overall this is a little clearer
- Add COPYRIGHT and AUTHOR sections in pod
* The old expression parser didn't work for some basic expressions I tested, and it was a bit difficult to debug because everything happened in the one evaluate() function * Replace the code with a parser based on the OpenBSD version * Parsing different operator priorities is delegated to different functions so overall this is a little clearer * Add COPYRIGHT and AUTHOR sections in pod %perl expr \( 1 \+ 1 \) \* 200 400 %perl expr "true" '&' '' 0 %perl expr 0 '|' 'true' true %perl expr 2 '*' 3 '+' 4 10 %perl expr 2 '+' 3 '*' 4 14 %perl expr "hotel" \: "ho" 2 %perl expr "hotel" \: "tel" # no match: regex is implicitly tied to start of string 0
Pull Request Test Coverage Report for Build 12379350747Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Michael Mikonos is responsible for a significant portion of the code so he gets credit too.
briandfoy
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: expr
The expr program
Status: released
there is a new release with this fix
Type: modernization
updating programs to current practices
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.