Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: patchfile argument may not be a directory #872

Merged
merged 1 commit into from
Dec 16, 2024
Merged

patch: patchfile argument may not be a directory #872

merged 1 commit into from
Dec 16, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Dec 16, 2024

  • Test case: perl patch orig.c .
  • Original file to patch is a regular file, patchfile argument is a directory
  • Previously patch would exit(0) for this case, but doing this fails to notify the user that anything went wrong
  • Tested against GNU version

@mknos
patch: patchfile argument may not be a directory
b1781b7 
* Test case: perl patch orig.c .
* Original file to patch is a regular file, patchfile argument is a directory
* Previously patch would exit(0) for this case, but doing this fails to notify the user that anything went wrong
* Tested against GNU version
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Dec 16, 2024
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing December 16, 2024 06:30 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Dec 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12347190657

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 72.464%
Totals Coverage Status
Change from base Build 12335567910: -0.7%
Covered Lines: 350
Relevant Lines: 483
💛 - Coveralls

@briandfoy briandfoy self-assigned this Dec 16, 2024
@briandfoy briandfoy merged commit e301515 into briandfoy:master Dec 16, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: patchfile argument may not be a directory

@briandfoy briandfoy added Status: accepted The fix is accepted Type: bug an existing feature does not work and removed Priority: low get to this whenever Type: enhancement improve a feature that already exists labels Dec 16, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy