Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

id: exit 1 on failure #846

Merged
merged 1 commit into from
Nov 30, 2024
Merged

id: exit 1 on failure #846

merged 1 commit into from
Nov 30, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 29, 2024

  • Avoid calling die() for better control of exit code
  • The pod manual stated the exit code would be 1, but for the NoSuchUser case it wasn't

@mknos
id: exit 1 on failure
3540ac4 
* Avoid calling die() for better control of exit code
* The pod manual stated the exit code would be 1, but for the NoSuchUser case it wasn't
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: id The id program labels Nov 29, 2024
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:45 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 29, 2024 08:46 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12081628934

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.069%
Totals Coverage Status
Change from base Build 12070185097: 0.0%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit 1ef9954 into briandfoy:master Nov 30, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: exit 1 on failure (not die with 255)

@briandfoy briandfoy added the Status: accepted The fix is accepted label Dec 2, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Dec 2, 2024
@briandfoy briandfoy self-assigned this Dec 4, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: id The id program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy