Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmod: symbolic file permissions #843

Merged
merged 1 commit into from
Nov 28, 2024
Merged

chmod: symbolic file permissions #843

merged 1 commit into from
Nov 28, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Nov 28, 2024

  • Sync mod() changes with bin/install
  • chmod would get some of the following symbolic permissions wrong...
perl chmod a= A               (0000/----------)
perl chmod a=rwx A            (0777/-rwxrwxrwx)
perl chmod u=rw A             (0600/-rw-------)
perl chmod u=rwx,g=w A        (0720/-rwx-w----)
perl chmod u=rx,g=r,o=r A     (0544/-r-xr--r--)

@mknos
chmod: symbolic file permissions
10ba15c 
* Sync mod() changes with bin/install
* chmod would get some of the following symbolic permissions wrong...
perl chmod a= ... (0000/----------)
perl chmod a=rwx A ... (0777/-rwxrwxrwx)
perl chmod u=rw A ... (0600/-rw-------)
perl chmod u=rwx,g=w A ... (0720/-rwx-w----)
perl chmod u=rx,g=r,o=r A ... (0544/-r-xr--r--)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chmod The chmod program labels Nov 28, 2024
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing November 28, 2024 04:26 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12062498978

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 12060052070: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy added Type: bug an existing feature does not work and removed Type: enhancement improve a feature that already exists labels Nov 28, 2024
@briandfoy briandfoy self-assigned this Nov 28, 2024
@briandfoy briandfoy merged commit d5feefe into briandfoy:master Nov 28, 2024
23 checks passed
@briandfoy
Copy link
Owner

changes: handle symbolic permissions correctly

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Nov 28, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: chmod The chmod program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy