Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: allow repeated search with // and ?? #768

Merged
merged 2 commits into from
Oct 24, 2024
Merged

ed: allow repeated search with // and ?? #768

merged 2 commits into from
Oct 24, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 23, 2024

  • In commit 78d5429, repeat search was only implemented for "/" and "?"
  • Add support for empty patterns specified as "??" and "//" (these may be followed by whitespace, but single "?" and "/" may not)
  • test1: "/\n" --> repeat search down
  • test2: "/ \n" --> start new search (down) for " "
  • test3: "// \n" --> repeat search down
  • test4: "?\n" --> repeat search up
  • test5: "? \n"--> start new search (up) for " "
  • test6: "?? \n --> repeat search up
  • Entering //n doesn't seem to work for repeating search then issuing n command (this could be supported later)

@mknos
ed: allow repeated search with // and ??
3c4b664 
* In commit 78d5429, repeat search was only implemented for "/" and "?"
* Add support for empty patterns specified as "??" and "//" (these may be followed by whitespace, but single "?" and "/" may not)
* test1: "/\n" --> repeat search down
* test2: "/ \n" --> start new search (down) for " "
* test3: "// \n" --> repeat search down
* test4: "?\n" --> repeat search up
* test5: "? \n"--> start new search (up) for " "
* test6: "?? \n --> repeat search up
* Entering //n doesn't seem to work for repeating search then issuing n command (this could be supported later)
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 23, 2024
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:16 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 23, 2024 06:17 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11490754978

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11467286540: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Oct 23, 2024
briandfoy
briandfoy requested changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's time to add these to the docs under editor commands.

@briandfoy briandfoy added the Status: changes requested adjust the pull request as noted in comments label Oct 23, 2024
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 24, 2024 01:10 — with GitHub Actions Inactive
@mknos
Copy link
Contributor Author

mknos commented Oct 24, 2024

Thanks for the reminder. I added a commit to document the search features, including global (g) command which doesn't support modifying the buffer at this time.

@briandfoy briandfoy merged commit 11e2c4c into briandfoy:master Oct 24, 2024
21 of 22 checks passed
@briandfoy
Copy link
Owner

changes: allow repeated search with // and ??

@briandfoy briandfoy removed the Status: changes requested adjust the pull request as noted in comments label Nov 8, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted Status: released there is a new release with this fix and removed Priority: low get to this whenever Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy