Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: -s silences warning in edEdit() #767

Merged
merged 1 commit into from
Oct 22, 2024
Merged

ed: -s silences warning in edEdit() #767

merged 1 commit into from
Oct 22, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 22, 2024

  • Go with the BSD treatment of -s flag: allow e command to open a new file (replacing the line buffer) without warning if the buffer was modified
  • This is more correct because in script mode (-s) ed is not being used interactively
  • This difference was discovered when testing OpenBSD version

@mknos
ed: -s silences warning in edEdit()
24a9eac 
* Go with the BSD treatment of -s flag: allow e command to open a new file (replacing the line buffer) without warning if the buffer was modified
* This is more correct because in script mode (-s) ed is not being used interactively
* This difference was discovered when testing OpenBSD version
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 22, 2024
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:17 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 22, 2024 01:18 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11451413198

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11443303929: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Oct 22, 2024
@briandfoy briandfoy merged commit 9f891d0 into briandfoy:master Oct 22, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -s now also suppresses diagnostics when editing a file

@briandfoy briandfoy removed the Priority: low get to this whenever label Oct 22, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Oct 22, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy