Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: basic repeated search #764

Merged
merged 1 commit into from
Oct 18, 2024
Merged

ed: basic repeated search #764

merged 1 commit into from
Oct 18, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 18, 2024

  • If I search for a pattern with "/hi" or "?bye" I want to repeat the search without re-entering the pattern (it might be much longer than "hi")
  • Allow typing a single "/" or "?" to repeat search down or up respectively (this will fail if a previous search was not performed)
  • GNU ed also allows repeating a search by typing empty pattern as "//" or "??", but that is not supported here for now

@mknos
ed: basic repeated search
36b7b09 
* If I search for a pattern with "/hi" or "?bye" I want to repeat the search without re-entering the pattern (it might be much longer than "hi")
* Allow typing a single "/" or "?" to repeat search down or up respectively (this will fail if a previous search was not performed)
* GNU ed also supports repeating search with empty pattern typed as "//" or "??" but that is not supported here for now
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Oct 18, 2024
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 18, 2024 12:08 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 18, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11403386005

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11368228359: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy self-assigned this Oct 18, 2024
@briandfoy briandfoy merged commit 78d5429 into briandfoy:master Oct 18, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: an empty search reuses the previous search

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 18, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy