Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: remove '==' alias for '=' #751

Merged
merged 1 commit into from
Oct 3, 2024
Merged

expr: remove '==' alias for '=' #751

merged 1 commit into from
Oct 3, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Oct 3, 2024

  • GNU version supports == but it is not standardised [1] and other versions do not support it
  • With patch applied, '==' results in syntax error, which is consistent with the OpenBSD version
  1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/expr.html

@mknos
expr: remove '==' alias for '='
29da32a 
* GNU version supports == but it is not standardised [1] and other versions do not support it
* With patch applied, '==' results in syntax error, which is consistent with the OpenBSD version

1. https://pubs.opengroup.org/onlinepubs/9699919799/utilities/expr.html
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: expr The expr program labels Oct 3, 2024
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:20 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:21 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing October 3, 2024 05:21 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Oct 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11156339010

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11127879927: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Oct 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11156339010

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11127879927: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

@briandfoy briandfoy merged commit fe7a248 into briandfoy:master Oct 3, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: == is no longer accepted as a synonym for = since this is not a standard option

@briandfoy briandfoy self-assigned this Oct 4, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Oct 4, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: expr The expr program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy