Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grep: silence stdin warning #744

Merged
merged 1 commit into from
Sep 24, 2024
Merged

grep: silence stdin warning #744

merged 1 commit into from
Sep 24, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Sep 24, 2024

  • Make this grep follow the BSD version better
  • A warning is already printed under trace mode (-T option) for each file argument processed, but there is no need to warn by default
  • GNU grep doesn't warn for this test case either
  • Fix a nit where the trace message is supposed to use the variable $name
  • While here, consistently append "\n" to error messages
%ifconfig | perl grep -T flags # after patch ...
grep: checking <STDIN>
eth0: flags=4099<UP,BROADCAST,MULTICAST>  mtu 1500
lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536

@mknos
grep: silence stdin warning
cedc6c4 
* Make this grep follow the BSD version better
* A warning is already printed under trace mode (-T option) for each file argument processed, but there is no need to warn by default
* GNU grep doesn't warn for this test case either
* Fix a nit where the trace message is supposed to use the variable $name

%ifconfig | perl grep -T flags # for example ...
grep: checking <STDIN>
eth0: flags=4099<UP,BROADCAST,MULTICAST>  mtu 1500
lo: flags=73<UP,LOOPBACK,RUNNING>  mtu 65536
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Sep 24, 2024
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:25 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing September 24, 2024 14:26 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Sep 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11015860666

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.069%
Totals Coverage Status
Change from base Build 11010435617: -0.7%
Covered Lines: 350
Relevant Lines: 479
💛 - Coveralls

briandfoy
briandfoy approved these changes Sep 24, 2024
View reviewed changes
@briandfoy briandfoy merged commit c84e378 into briandfoy:master Sep 24, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: silence a warning from grep reading stdin.

@briandfoy briandfoy added the Type: bug an existing feature does not work label Sep 24, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Type: enhancement improve a feature that already exists Priority: low get to this whenever labels Sep 24, 2024
@briandfoy briandfoy self-assigned this Sep 24, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: grep The grep program Status: released there is a new release with this fix Type: bug an existing feature does not work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy