-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grep: -q and -s options reversed #708
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mknos
commented
Aug 8, 2024
•
edited
Loading
edited
- This grep has the standard meanings of options -s and -q backwards [1]
- -s is to suppress some errors
- -q is to make grep not show matches, and perform a quick search of one match per file
- test1: "perl grep -c yo grep" --> count the matches of "yo"
- test2: "perl grep -cv yo grep"--> count the lines not matching "yo"
- test3: "perl grep -q perl grep" --> quiet search for "perl"; exit status 0 indicates Match
- test4: "perl grep -q pascal grep" --> quiet search for "pascal"; exit status 1 indicates NoMatch
- test5: "perl grep -s greg greg" --> silent search for "greg" but the file doesn't exist; exit status 2 indicates Error
- Correct POD manual and usage string
- https://pubs.opengroup.org/onlinepubs/009604299/utilities/grep.html
* This grep has the standard meanings of options -s and -q backwards [1] * -s is to suppress some errors * -q is to make grep not show matches, and perform a quick search of one match per file * test1: "perl grep -c yo grep" --> count the matches of "yo" * test2: "perl grep -cv yo grep"--> count the lines not matching "yo" * test3: "perl grep -q perl grep" --> quiet search for "perl"; exit status 0 indicates Match * test4: "perl grep -q pascal grep" --> quiet search for "pascal"; exit status 1 indicates NoMatch * test4: "perl grep -s greg greg" --> silent search for "greg" but the file doesn't exist; exit status 2 indicates Error * Correct POD manual and usage string 1. https://pubs.opengroup.org/onlinepubs/009604299/utilities/grep.html
Pull Request Test Coverage Report for Build 10303258577Details
💛 - Coveralls |
briandfoy
approved these changes
Aug 8, 2024
changes: -s and -q were swapped in previous versions. -s is for suppressing errors, -q is for not showing matches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Program: grep
The grep program
Status: released
there is a new release with this fix
Type: enhancement
improve a feature that already exists
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.