Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grep: -q and -s options reversed #708

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 8, 2024

  • This grep has the standard meanings of options -s and -q backwards [1]
  • -s is to suppress some errors
  • -q is to make grep not show matches, and perform a quick search of one match per file
  • test1: "perl grep -c yo grep" --> count the matches of "yo"
  • test2: "perl grep -cv yo grep"--> count the lines not matching "yo"
  • test3: "perl grep -q perl grep" --> quiet search for "perl"; exit status 0 indicates Match
  • test4: "perl grep -q pascal grep" --> quiet search for "pascal"; exit status 1 indicates NoMatch
  • test5: "perl grep -s greg greg" --> silent search for "greg" but the file doesn't exist; exit status 2 indicates Error
  • Correct POD manual and usage string
  1. https://pubs.opengroup.org/onlinepubs/009604299/utilities/grep.html

* This grep has the standard meanings of options -s and -q backwards [1]
* -s is to suppress some errors
* -q is to make grep not show matches, and perform a quick search of one match per file
* test1: "perl grep -c yo grep" --> count the matches of "yo"
* test2: "perl grep -cv yo grep"-->  count the lines not matching "yo"
* test3: "perl grep -q perl  grep" --> quiet search for "perl"; exit status 0 indicates Match
* test4: "perl grep -q pascal grep" --> quiet search for "pascal"; exit status 1 indicates NoMatch
* test4: "perl grep -s greg greg" --> silent search for "greg" but the file doesn't exist; exit status 2 indicates Error
* Correct POD manual and usage string

1. https://pubs.opengroup.org/onlinepubs/009604299/utilities/grep.html
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: grep The grep program labels Aug 8, 2024
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:41 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 8, 2024 13:42 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 10303258577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 73.375%

Totals Coverage Status
Change from base Build 10300132695: -0.7%
Covered Lines: 350
Relevant Lines: 477

💛 - Coveralls

@briandfoy briandfoy merged commit b0e27ac into briandfoy:master Aug 8, 2024
22 of 23 checks passed
@briandfoy
Copy link
Owner

changes: -s and -q were swapped in previous versions. -s is for suppressing errors, -q is for not showing matches

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Program: grep The grep program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants