Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pr -0 causes divzero #698

Merged
merged 1 commit into from
Aug 5, 2024
Merged

pr -0 causes divzero #698

merged 1 commit into from
Aug 5, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 5, 2024

  • The -NUM option can be used for setting column count, but -0 is not a valid input
%perl pr -0  a.c
Illegal division by zero at pr line 338.
  • When tracing this, COLINFO list is empty and $columns is zero
  • Follow GNU implementation and raise error for -0

@mknos
pr -0 causes divzero
fe90e82 
* The -NUM option can be used for setting column count, but -0 is not a valid input
```
%perl pr -0  a.c
Illegal division by zero at pr line 338.
```
*  When tracing this, COLINFO list is empty and $columns is zero
* Follow GNU implementation and raise error for -0
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: pr The pr program labels Aug 5, 2024
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 5, 2024 09:38 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 5, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10246396390

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10245698840: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy
Copy link
Owner

changes: don't let column count be zero (no -0 allowed)

@briandfoy briandfoy self-assigned this Aug 5, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 5, 2024
@briandfoy briandfoy merged commit abcf456 into briandfoy:master Aug 5, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
@briandfoy briandfoy added the Type: compatability make it work like GNU or BSD label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: pr The pr program Status: released there is a new release with this fix Type: compatability make it work like GNU or BSD Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy