Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: retire Patch::import() #694

Merged
merged 1 commit into from
Aug 2, 2024
Merged

patch: retire Patch::import() #694

merged 1 commit into from
Aug 2, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 2, 2024

  • Program is written in oo-style with subclasses of Patch (Context, Ed, Normal and Unified)
  • Declare subclasses as subclasses with "use base" instead of calling Patch->import() manually
  • Now the custom import() code can be deleted
  • Two example methods called from subclass are note() and throw()
  • I noticed this when searching for "no strict" within bin/ directory
  • test1: patch a normal diff (output of "diff a.c b.c")
  • test2: patch a unified diff (output of "diff -u a.c b.c")
  • test3: patch an ed diff (output of "diff -e a.c b.c")
  • test4: patch a context diff (output of "diff -c a.c b.c")

@mknos
patch: retire Patch::import()
514c49c 
* Program is written in oo-style with subclasses of Patch (Context, Ed, Normal and Unified) 
* Declare subclasses as subclasses with "use base" instead of calling Patch->import() manually
* Now the custom import() code can be deleted
* Two example methods called from subclass are note() and throw()
* I noticed this when searching for "no strict" within bin/ directory
* test1: patch a normal diff (output of "diff a.c b.c")
* test2: patch a unified diff (output of "diff -u a.c b.c")
* test3: patch an ed diff (output of "diff -e a.c b.c")
* test4: patch a context diff (output of "diff -c a.c b.c")
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: patch The patch program labels Aug 2, 2024
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:08 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 2, 2024 02:09 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 2, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10208803325

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10176256664: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

@briandfoy briandfoy merged commit 6230d51 into briandfoy:master Aug 2, 2024
22 of 23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Aug 2, 2024
@briandfoy briandfoy self-assigned this Aug 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: patch The patch program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy