Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fold: add getopts() #692

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fold: add getopts() #692

merged 1 commit into from
Aug 2, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Aug 1, 2024

  • Reduce the amount of custom code for pre-posix argument handling of -NUM
  • Pre-process ARGV by converting -123 to -w123, then hand off to getopts()
  • Prefix usage string with "usage:"
  • Sync usage string with pod document; no need to encourage people to use the old -NUM form for width
  • test1: "echo perl cat cat | perl fold -40" --> process stdin with -w 40
  • test2: "perl fold -s -w 72 moo" --> regular -w form with file input instead of stdin

@mknos
fold: add getopts()
90a42b5 
* Reduce the amount of custom code for pre-posix argument handling of -NUM
* Pre-process ARGV by converting -123 to -w123, then hand off to getopts()
* Prefix usage string with "usage:"
* Sync usage string with pod document; no need to encourage people to use the old -NUM form for width
* test1: "echo `perl cat cat` | perl fold -40" --> process stdin with -w 40
* test2: "perl fold -s -w 72 moo" --> regular -w form with file input instead of stdin
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: fold The fold program labels Aug 1, 2024
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing August 1, 2024 08:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Aug 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10194860944

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.7%) to 76.268%
Totals Coverage Status
Change from base Build 10176256664: -0.7%
Covered Lines: 376
Relevant Lines: 493
💛 - Coveralls

briandfoy
briandfoy approved these changes Aug 2, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these programs your catching out on this make me want to find what when GetOpts was part of perl core. I think Getopt::Std was in the first release of Perl 5 though.

@briandfoy briandfoy merged commit 31f2a77 into briandfoy:master Aug 2, 2024
22 of 23 checks passed
@briandfoy briandfoy self-assigned this Aug 2, 2024
@briandfoy briandfoy added the Status: accepted The fix is accepted label Aug 2, 2024
@briandfoy briandfoy removed the Priority: low get to this whenever label Aug 2, 2024
@briandfoy
Copy link
Owner

changes: use getopts to handle argument processing

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: fold The fold program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mknos @coveralls @briandfoy