Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tail: tweak filename title #653

Merged
merged 1 commit into from
Jun 14, 2024
Merged

tail: tweak filename title #653

merged 1 commit into from
Jun 14, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jun 14, 2024

  • Make tail use "==> FILENAME <==\n" format when printing output from multiple files; this conforms with GNU and OpenBSD versions
  • This is also consistent with the filename title printed by bin/head
  • test: same md5 sum compared to tail(1) on my Linux system: "perl tail -n 50 awk ar arithmetic | md5sum"
  • While here, delete dead code in parse_args(); $point is always assigned a default value of -10 at top of function

@mknos
tail: tweak filename title
ce70471 
* Make tail use "==> FILENAME <==\n" format when printing output from multiple files; this conforms with GNU and OpenBSD versions
* This is also consistent with the filename title printed by bin/head
* test: same md5 sum compared to tail(1) on my Linux system: "perl tail -n 50 awk ar arithmetic | md5sum"
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: tail The tail program labels Jun 14, 2024
briandfoy
briandfoy approved these changes Jun 14, 2024
View reviewed changes
Copy link
Owner

@briandfoy briandfoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like the consistency you're adding to PerlPowerTools.

@briandfoy briandfoy merged commit 41e7758 into briandfoy:master Jun 14, 2024
2 checks passed
@briandfoy
Copy link
Owner

changes: filename header for multiple file output now matches GNU and BSD, and the head program in PerlPowerTools

@briandfoy briandfoy self-assigned this Jun 14, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jun 14, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: tail The tail program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy