Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ar: file header not printed for -q #495

Merged
merged 1 commit into from
Mar 12, 2024
Merged

ar: file header not printed for -q #495

merged 1 commit into from
Mar 12, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Mar 11, 2024

  • In quick-append mode (-q), ar creates a file if it doesn't exist and appends to a file if it exists
  • I discovered that if a file is created in this way, the valid header record is not printed, making the archive invalid
  • GNU ar is smart enough to print file header in this case
  • step1: quickly create archive with one file: perl ar -q new.ar addbib
  • step2: append another file to archive: perl ar -q new.ar asa
  • step3: list files in archive: perl ar -t new.ar

@mknos
ar: file header not printed for -q
e083fce 
* In quick-append mode (-q), ar creates a file if it doesn't exist and appends to a file if it does
* I discovered that if a file is created in this way, the valid header record is not printed, making the archive invalid
* step1: quickly create archive with one file: perl ar -q new.ar addbib (GNU ar is smart enough to print file header in this case)
* step2: append another file to archive: perl ar -q new.ar asa
* step3: list files in archive: perl ar -t new.ar
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ar The ar program labels Mar 11, 2024
@briandfoy briandfoy self-assigned this Mar 12, 2024
@briandfoy briandfoy merged commit c87c722 into briandfoy:master Mar 12, 2024
2 checks passed
@briandfoy
Copy link
Owner

changes: ensure file has header with -q, which should have happened before but wasn't

@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Mar 12, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briandfoy briandfoy

Labels
Program: ar The ar program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy