Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asa: regex too greedy #476

Merged
merged 1 commit into from
Mar 1, 2024
Merged

asa: regex too greedy #476

merged 1 commit into from
Mar 1, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Mar 1, 2024

  • Problem1: asa would refuse to open a file with a dash
  • Problem2: if opening a file fails, asa did not proceed to the next file argument
  • This patch brings the code closer to NetBSD version [1]
  • test1: "echo hi | perl asa" --> no args; read stdin
  • test2: "perl asa real-file" --> one file argument; real-file is not a command option
  • test3: "perl asa notfound real-file" --> warn for not opening 'notfound', process 'real-file' then exit with code 1 to indicate error
  1. http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/asa/asa.c?annotate=1.17

@mknos
asa: regex too greedy
04996fb 
* Problem1: asa would refuse to open a file with a dash
* Problem2: if opening a file fails, asa did not proceed to the next file argument
* This patch brings the code closer to NetBSD version [1]
* test1: "echo hi | perl asa" --> no args; read stdin
* test2: "perl asa real-file" --> one file argument; real-file is not a command option
* test3: "perl asa notfound real-file" --> warn for not opening 'notfound', process 'real-file' then exit with code 1 to indicate error

1.  http://cvsweb.netbsd.org/bsdweb.cgi/src/usr.bin/asa/asa.c?annotate=1.17
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: asa The asa program labels Mar 1, 2024
@briandfoy briandfoy merged commit d783ed2 into briandfoy:master Mar 1, 2024
2 checks passed
@briandfoy briandfoy self-assigned this Mar 3, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Mar 3, 2024
@briandfoy
Copy link
Owner

changes: fix problem reading a file with a dash in name

@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: asa The asa program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy