Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ed: simplify backwards search #414

Merged
merged 2 commits into from
Jan 24, 2024
Merged

ed: simplify backwards search #414

merged 2 commits into from
Jan 24, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 24, 2024

  • In edSearchBackwards(), init $line index directly instead of copying value from $start
  • I found this by accident when reading the code
  • Test jumps to line 60, finds "perl" patten backwards on line 9 then again on 7
%perl ed -p '>>> ' awk
4595
>>> 60
open(TMPOUT, '+>', ($tmpout = "/tmp/a2pout.$$"))    ||
>>> ?perl
License: perl
>>> n
9	License: perl
>>> ?perl
Author: Tom Christiansen, tchrist@perl.com
>>> n
7	Author: Tom Christiansen, tchrist@perl.com
>>> q

@mknos
ed: simplify backwards search
6df8efd 
* In edSearchBackwards(), init $line index directly instead of copying value from $start
* I found this by accident when reading the code
* Test jumps to line 60, finds "perl" patten backwards on line 9 then again on 7

%perl ed -p '>>> ' awk
4595
>>> 60
open(TMPOUT, '+>', ($tmpout = "/tmp/a2pout.$$"))    ||
>>> ?perl
License: perl
>>> n
9	License: perl
>>> ?perl
Author: Tom Christiansen, tchrist@perl.com
>>> n
7	Author: Tom Christiansen, tchrist@perl.com
>>> q
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: ed The ed program labels Jan 24, 2024
@briandfoy briandfoy self-assigned this Jan 24, 2024
@briandfoy briandfoy merged commit 42e50d8 into briandfoy:master Jan 24, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 24, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: ed The ed program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy