Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primes: error for numbers with trailing non-digits #406

Merged
merged 1 commit into from
Jan 13, 2024
Merged

primes: error for numbers with trailing non-digits #406

merged 1 commit into from
Jan 13, 2024

Conversation

mknos
Copy link
Contributor

@mknos mknos commented Jan 13, 2024

  • This version of primes accepts garbage characters at the end of number arguments Start and End
  • e.g. "primes 1xxx 9yyy" is accepted as "primes 1 9"
  • Align with OpenBSD behaviour and print an error for this
  • I still want to discover why 2 appears before 1 in the output

@mknos
primes: error for numbers with trailing non-digits
4d1f3c2 
* This version of primes accepts garbage characters at the end of number arguments Start and End 
* e.g. "primes 1xxx 9yyy" is accepted as "primes 1 9"
* Align this version with OpenBSD and print an error for this
* I still want to discover why 2 appears before 1 in the output
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: primes The primes program labels Jan 13, 2024
@briandfoy briandfoy self-assigned this Jan 13, 2024
@briandfoy briandfoy merged commit 2eaeb95 into briandfoy:master Jan 13, 2024
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Jan 13, 2024
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels
Program: primes The primes program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mknos @briandfoy